Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

2023-04-18 Thread Lionel Henry
> Do note that the root cause remains on the ESS side - `run-ess-r' in > Emacs 27, when called non-interactively, may set line splitting to > something strange. I think you're right. Probably we shouldn't be executing screen options when called non-interactively and instead leave the R default

Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

2023-04-18 Thread Ihor Radchenko
Lionel Henry writes: > Can you try with the latest commit please? > https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e Works now. Thank you! > By the way, it looks like you're setting the width in the exported > initialization routine rather than just in tests.

Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

2023-04-18 Thread Lionel Henry
Can you try with the latest commit please? https://github.com/emacs-ess/ESS/commit/ed6c12ee3dfb1046fb030200f45e75a65b31e49e By the way, it looks like you're setting the width in the exported initialization routine rather than just in tests. For user-facing features at least you probably want to

Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

2023-04-18 Thread Lionel Henry
Hi Ihor, Thanks for looking into this. I think you're right it's probably caused by ESS now setting the width on startup. In that case you could fix your tests by setting `options(width = )` to some hardcoded value. You could do it via `ess-r-post-run-hook`. Best, Lionel On 4/17/23, Ihor

Re: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

2023-04-18 Thread Ihor Radchenko
Lionel Henry writes: > Thanks for looking into this. I think you're right it's probably > caused by ESS now setting the width on startup. In that case you could > fix your tests by setting `options(width = )` to some hardcoded value. > You could do it via `ess-r-post-run-hook`. I tried using

[BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]

2023-04-17 Thread Ihor Radchenko
Steps to reproduce: 1. cd /path/to/org/git/repo 2. make test EMACS=emacs-27 BTEST_POST="-L /path/to/ESS/lisp -l ob-R -l ess -l ess-r-mode" BTEST_RE="async" 3 unexpected results: FAILED ob-session-async-R-named-output FAILED ob-session-async-R-output-drawer FAILED