Re: [BUG] ob-sql sql-connection-alist

2023-01-30 Thread Daniel Kraus
Hi! Andreas Gerler writes: > I added the missing changelog entry. Thanks. I installed the patch. (I'll also answer to your dbconnection engine mail soon. Just very busy atm) Thanks, Daniel

Re: [BUG] ob-sql sql-connection-alist

2023-01-28 Thread Andreas Gerler
Hi! I added the missing changelog entry. 0001-lisp-ob-sql.el-allow-string-in-sql-connection-alist.patch Description: Binary data > On 27. Jan 2023, at 17:58, Andreas Gerler > wrote: > > Hi! > > I can prepare a new commit this weekend. > so long… Andreas Gerler —

Re: [BUG] ob-sql sql-connection-alist

2023-01-27 Thread Andreas Gerler
Hi! I can prepare a new commit this weekend. so long... Andreas > On Jan 27, 2023, at 2:18 PM, Ihor Radchenko wrote: > > Bastien Guerry writes: > >> It was missing in the FSF copyright.list file, but it has been fixed >> and Andreas can be added as a regular contributor. > > Done. >

Re: [BUG] ob-sql sql-connection-alist

2023-01-27 Thread Ihor Radchenko
Bastien Guerry writes: > It was missing in the FSF copyright.list file, but it has been fixed > and Andreas can be added as a regular contributor. Done. https://git.sr.ht/~bzg/worg/commit/3dbeb2db -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [BUG] ob-sql sql-connection-alist

2023-01-27 Thread Ihor Radchenko
Bastien Guerry writes: >> Bastien, could you please confirm the copyright status of Andreas >> Gerler? > > It was missing in the FSF copyright.list file, but it has been fixed > and Andreas can be added as a regular contributor. Daniel, there is thus no obstacle installing the patch. And no

Re: [BUG] ob-sql sql-connection-alist

2023-01-26 Thread Bastien Guerry
Hi, Ihor Radchenko writes: > Bastien, could you please confirm the copyright status of Andreas > Gerler? It was missing in the FSF copyright.list file, but it has been fixed and Andreas can be added as a regular contributor. Best, -- Bastien

Re: [BUG] ob-sql sql-connection-alist

2023-01-22 Thread Bastien Guerry
Hi, Ihor Radchenko writes: > Bastien, could you please confirm the copyright status of Andreas > Gerler? I cannot find any entry with "Gerler" as a name, or with the email "ba...@bundesbrandschatzamt.de". Andreas, can you write me in private with a copy of the signed FSF copyright assignment?

Re: [BUG] ob-sql sql-connection-alist

2023-01-21 Thread Andreas Gerler
The copyright assignment was in April 2017. gnu.org #1203873 if that helps. > On 21. Jan 2023, at 09:48, Ihor Radchenko wrote: > > Daniel Kraus writes: > >> @Ihor, since this is the first patch I install from another contributor, >> is there anything I should look out for? > >> E.g. does

Re: [BUG] ob-sql sql-connection-alist

2023-01-21 Thread Ihor Radchenko
Daniel Kraus writes: > @Ihor, since this is the first patch I install from another contributor, > is there anything I should look out for? > E.g. does this need a TINYCHANGE entry or something? 1. General checks for tests passing and sanity of the patches 2. Ensuring copyright status, when

Re: [BUG] ob-sql sql-connection-alist

2023-01-20 Thread Andreas Gerler
Hi Daniel, I already contributed to Orgmode a few years ago for Vertica support and filled the copyright assignment back then. Andreas > On Jan 20, 2023, at 9:47 PM, Daniel Kraus wrote: > > Thanks. > > @Ihor, since this is the first patch I install from another contributor, > is there

Re: [BUG] ob-sql sql-connection-alist

2023-01-20 Thread Daniel Kraus
Thanks. @Ihor, since this is the first patch I install from another contributor, is there anything I should look out for? E.g. does this need a TINYCHANGE entry or something? Or do you have already copyright assignments filled out, Andreas and then it's not necessary? Can I see somewhere who I

Re: [BUG] ob-sql sql-connection-alist

2023-01-20 Thread Andreas Gerler
Sorry. That was the wrong patch. 0001-lisp-ob-sql.el-allow-string-in-sql-connection-alist.patch Description: Binary data > On 20. Jan 2023, at 18:24, Andreas Gerler > wrote: > > <0001-lisp-ob-eval.el-Display-error-fix.patch> > >> On 16. Jan 2023, at 11:25, Daniel Kraus wrote: >> >> Hi!

Re: [BUG] ob-sql sql-connection-alist

2023-01-20 Thread Andreas Gerler
0001-lisp-ob-eval.el-Display-error-fix.patch Description: Binary data > On 16. Jan 2023, at 11:25, Daniel Kraus wrote: > > Hi! > > Andreas Gerler writes: > >> Last week I heard about using ob-sql with credentials stored in the variable >> used by isql. >> However I had to modify ob-sql

Re: [BUG] ob-sql sql-connection-alist

2023-01-16 Thread Ihor Radchenko
Daniel Kraus writes: >> I am looking at the docstring of `sql-connection-alist': >> >> An alist of connection parameters for interacting with a SQL product. >> Each element of the alist is as follows: >> >>(CONNECTION \(SQL-VARIABLE VALUE) ...) >> >> Where CONNECTION is a

Re: [BUG] ob-sql sql-connection-alist

2023-01-16 Thread Daniel Kraus
Ihor Radchenko writes: > Andreas Gerler writes: >> (setq sql-connection-alist >> '((testdb (sql-product 'mysql) >> (sql-server "127.0.0.1") >> (sql-user "mysql”) >> (sql-port 3306) >> (sql-password “foo") >>

Re: [BUG] ob-sql sql-connection-alist

2023-01-16 Thread Ihor Radchenko
Andreas Gerler writes: > Last week I heard about using ob-sql with credentials stored in the variable > used by isql. > However I had to modify ob-sql to get it actually working. > Can somebody test the pach before I send in a commit? > > #+begin_src sql :engine mysql :dbconnection testdb >

Re: [BUG] ob-sql sql-connection-alist

2023-01-16 Thread Daniel Kraus
Hi! Andreas Gerler writes: > Last week I heard about using ob-sql with credentials stored in the variable > used by isql. > However I had to modify ob-sql to get it actually working. > Can somebody test the pach before I send in a commit? > > #+begin_src sql :engine mysql :dbconnection testdb

[BUG] ob-sql sql-connection-alist

2023-01-15 Thread Andreas Gerler
HI! Last week I heard about using ob-sql with credentials stored in the variable used by isql. However I had to modify ob-sql to get it actually working. Can somebody test the pach before I send in a commit? #+begin_src sql :engine mysql :dbconnection testdb show tables; #+end_src (setq