Allen Li writes:
>> If someone is willing to check all the occurrences of
>> (defvar +[^ ]+ +nil) and remove nil values where we merely put a defvar
>> to silence byte-compiler, please do it.
>
> My initial request was just to fix this one instance that is actively
> troubling me. If there are
Ihor Radchenko writes:
> Unfortunately, fixing the occurrences of (defvar foo nil) is not
> completely straightforward. Some of them are real defvars.
I see, I thought you meant those defvars were also used for dynamic
scoping.
>
> If someone is willing to check all the occurrences of
> (defvar
Allen Li writes:
> I see. In my opinion those occurrences should be fixed even if no one
> is reporting issues because it is bad/improper code, and it is not
> especially surprising that no one has reported it yet; there is always a
> first person who reports a bug, and there are always more
Ihor Radchenko writes:
> Allen Li writes:
>
>>> I agree. The question is whether changing to
>>> (defvar org-id-link-to-org-use-id)
>>> solves your problem.
>>
>> Thanks for your concern. By editing ob-tangle.el, I can confirm that
>> changing this does solve my problem.
>>
>> If I must, I
Allen Li writes:
>> I agree. The question is whether changing to
>> (defvar org-id-link-to-org-use-id)
>> solves your problem.
>
> Thanks for your concern. By editing ob-tangle.el, I can confirm that
> changing this does solve my problem.
>
> If I must, I could provide a reproducible example,
Ihor Radchenko writes:
> Allen Li writes:
>> Even if org-id-link-to-org-use-id were always set at this point, there
>> would be no reason to use
>>
>> (defvar org-id-link-to-org-use-id nil)
>>
>> instead of
>>
>> (defvar org-id-link-to-org-use-id)
>
> I agree. The question is whether changing
Allen Li writes:
>> Allen Li writes:
>>
>>> In ob-tangle.el, the line
>>>
>>> (defvar org-id-link-to-org-use-id nil) ; Dynamically scoped
>>>
>>> appears to override the user's customization of
>>> org-id-link-to-org-use-id.
>>
>> Have you seen this happening?
>
> Yes, that's why I filed the
Ihor Radchenko writes:
> Allen Li writes:
>
>> In ob-tangle.el, the line
>>
>> (defvar org-id-link-to-org-use-id nil) ; Dynamically scoped
>>
>> appears to override the user's customization of
>> org-id-link-to-org-use-id.
>
> Have you seen this happening?
Yes, that's why I filed the bug.
>
Allen Li writes:
> In ob-tangle.el, the line
>
> (defvar org-id-link-to-org-use-id nil) ; Dynamically scoped
>
> appears to override the user's customization of
> org-id-link-to-org-use-id.
Have you seen this happening?
FYI, defvar does not overwrite variable value that is already set.
Try the
In ob-tangle.el, the line
(defvar org-id-link-to-org-use-id nil) ; Dynamically scoped
appears to override the user's customization of
org-id-link-to-org-use-id.
Specifically, this happens if the user has python in
org-babel-do-load-languages, which leads to the require chain:
require
10 matches
Mail list logo
