Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-22 Thread Bastien Guerry
Hi Ihor and Ignacio, sorry for the late answer. Ihor Radchenko writes: > Bastien, could you kindly check if Ignacio Casso > has FSF assignment and update contributors > page accordingly? I confirm Ignacio has FSF assignment (since 2022-03-28) and I updated the Org contributors page. Best,

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-08 Thread Ihor Radchenko
Ignacio Casso writes: >> I have added TINYCHANGE cookie as you don't appear to have FSF copyright > > I should have it, I did the paperwork for commit 2b564f504b in > Emacs. Maybe I used a different email? Or maybe the problem is that now > that I see it I don't have my full name configured in

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-08 Thread Ignacio Casso
> Thanks! Thank you too! > I have added TINYCHANGE cookie as you don't appear to have FSF copyright I should have it, I did the paperwork for commit 2b564f504b in Emacs. Maybe I used a different email? Or maybe the problem is that now that I see it I don't have my full name configured in git.

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-08 Thread Ihor Radchenko
Ignacio Casso writes: > Done. I attach the patch: Thanks! Applied onto main as a3dd2 with minor amendments. I have added TINYCHANGE cookie as you don't appear to have FSF copyright assignment and capitalised "match" in the commit summary. Best, Ihor > From

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-07 Thread Ignacio Casso
Ihor Radchenko writes: > Ignacio Casso writes: > >>> Sounds reasonable. Could you prepare a patch? >>> COMMENT should be inside a shy group and note that there might be an >>> arbitrary number of space after COMMENT string. >> >> Here it is. > > Thanks! Could you also update the

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-06 Thread Ihor Radchenko
Ignacio Casso writes: >> Sounds reasonable. Could you prepare a patch? >> COMMENT should be inside a shy group and note that there might be an >> arbitrary number of space after COMMENT string. > > Here it is. Thanks! Could you also update the org-complex-heading-regexp-format docstring and

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-06 Thread Ignacio Casso
> Sounds reasonable. Could you prepare a patch? > COMMENT should be inside a shy group and note that there might be an > arbitrary number of space after COMMENT string. Here it is. >From 54cd366c97bd64c226cc6fc79e125ee9f026ff66 Mon Sep 17 00:00:00 2001 From: Ignacio Date: Fri, 6 May 2022

Re: [BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-06 Thread Ihor Radchenko
Ignacio Casso writes: >> Note that org-complex-heading-regexp-format does consider statistics >> cookies, but only at the beginning/end of the headline title. >> Unfortunately, it is impossible to provide generic printf format to >> match a headline title with arbitrary statistics cookies

[BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-05-05 Thread Ignacio Casso
This topic was brought up again in https://lists.gnu.org/archive/html/emacs-orgmode/2022-05/msg00058.html, I continue the discussion here: >> Still, I think it might be interesting to compare this topic with the >> one I linked in my reply, >>

[BUG] org-complex-heading-regexp should consider COMMENT keywords [9.5.2 (release_9.5.2-25-gaf6f12 @ /home/ignacio/repos/emacs/lisp/org/)]

2022-03-22 Thread Ignacio Casso
Hello, I think `org-complex-heading-regexp' and `org-complex-heading-regexp-format' should consider COMMENT keywords, as they do with TODO keywords, priorities, and tags. Firstly, with things as they are, different methods for accessing the headline text are inconsistent. For example, for the