Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2023-01-27 Thread Jack Kamm
Ihor Radchenko writes: > Let's follow the usual approach and first deprecate it. It should become > a constant with 'python value in org-compat.el. Deprecating is not make > sure that other packages that might be testing the variable value do not > get broken. > > Note that we usually `quote'

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2023-01-23 Thread Ihor Radchenko
Jack Kamm writes: > Ihor Radchenko writes: > >> Marked for future removal in ob-python.el. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21741a469 > > Thanks Ihor. > > Not sure if it's too early for this, but I've prepared a patch to remove > the support for python-mode.el,

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2023-01-22 Thread Jack Kamm
Ihor Radchenko writes: > Marked for future removal in ob-python.el. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21741a469 Thanks Ihor. Not sure if it's too early for this, but I've prepared a patch to remove the support for python-mode.el, attached. Also, to help any

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-12-29 Thread Bastien
Ihor Radchenko writes: > Marked for future removal in ob-python.el. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=21741a469 Thanks! -- Bastien

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-12-29 Thread Ihor Radchenko
Bastien Guerry writes: > Ihor Radchenko writes: > >> I am leaning towards announcing the deprecation in the coming >> release. > > Agreed, let's move forward in this direction for the release. Marked for future removal in ob-python.el.

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-11-26 Thread Bastien
Ihor Radchenko writes: > Done: https://orgmode.org/list/87lenyjaxx.fsf@localhost > > I also added NEWS entry > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6db75d560 Thanks! -- Bastien

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-11-26 Thread Ihor Radchenko
Bastien writes: > Jack Kamm writes: > >> If python-mode support is removed, I'd be willing to help create a new >> ob-python-mode package > > Indeed. A suggestion: can you or Ihor send a help request to the > list, explaining the issue at hand and asking if someone wants to > create and

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-11-25 Thread Bastien
Jack Kamm writes: > If python-mode support is removed, I'd be willing to help create a new > ob-python-mode package Indeed. A suggestion: can you or Ihor send a help request to the list, explaining the issue at hand and asking if someone wants to create and maintain ob-python-mode.el? This

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python?

2022-11-25 Thread Bastien Guerry
Ihor Radchenko writes: > I am leaning towards announcing the deprecation in the coming > release. Agreed, let's move forward in this direction for the release. -- Bastien

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python? (was: [BUG] ob-python: async session evaluation does not support python-mode.el [9.6-pre (

2022-11-25 Thread Ihor Radchenko
Ihor Radchenko writes: > Should we deprecate the support altogether and not bother with the extra > maintenance? Or maybe someone want to volunteer maintaining > python-mode.el integration? No objections have been received. Also, python-mode support have been broken for a long time now and no

Re: [DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python? (was: [BUG] ob-python: async session evaluation does not support python-mode.el [9.6-pre (

2022-11-03 Thread Jack Kamm
Ihor Radchenko writes: > However, supporting python-mode.el integration is difficult for Org > team: neither the current ob-python maintainer nor the rest of Org team > are familiar with python-mode.el. > > The bug discussed above already shows that parts of ob-python do not > work properly with

[DISCUSSION] Should we deprecate python-mode.el (alternative to built-in python.el) support in ob-python? (was: [BUG] ob-python: async session evaluation does not support python-mode.el [9.6-pre (rele

2022-11-03 Thread Ihor Radchenko
Jack Kamm writes: > I was actually planning to deprecate ob-python support for > python-mode.el, because I don't think it's worth the extra complexity & > burden to support 2 python modes. For users who prefer python-mode, I > think it would be better to have a separate ob-python-mode, perhaps