Re: [FR] Should we resolve environment variables in the file link path when exporting? (was: [FR] Please add environment variable substitution in `org-display-inline-images')

2023-07-31 Thread Ihor Radchenko
Ihor Radchenko writes: > I generally feel that it should be reasonable to go ahead with this > breaking change, possibly disabling variable resolution for ox-org only. Done, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f409cb4e5 -- Ihor Radchenko // yantar92, Org mo

Re: [FR] Should we resolve environment variables in the file link path when exporting? (was: [FR] Please add environment variable substitution in `org-display-inline-images')

2023-06-01 Thread Ihor Radchenko
Pan Xie writes: > Oh, that path will be horrible! Variable substitution is really > important since it is an abstraction to make the same org file works on > different hosts with different path hierarchies. I believe there are > lots of users already rely on it, even without being documented.

Re: [FR] Should we resolve environment variables in the file link path when exporting? (was: [FR] Please add environment variable substitution in `org-display-inline-images')

2023-06-01 Thread Pan Xie
Oh, that path will be horrible! Variable substitution is really important since it is an abstraction to make the same org file works on different hosts with different path hierarchies. I believe there are lots of users already rely on it, even without being documented. The reasonable thinking w

Re: [FR] Should we resolve environment variables in the file link path when exporting? (was: [FR] Please add environment variable substitution in `org-display-inline-images')

2023-06-01 Thread Ihor Radchenko
Pan Xie writes: > I think we need keep consistent with the file link. Since file link will > substitute the environment variables in its file path, I guess it will > do the same thing when export to html files. It may keep the variables > when export to Org (ox-org). Since both image link and

Re: [FR] Should we resolve environment variables in the file link path when exporting? (was: [FR] Please add environment variable substitution in `org-display-inline-images')

2023-06-01 Thread Pan Xie
I think we need keep consistent with the file link. Since file link will substitute the environment variables in its file path, I guess it will do the same thing when export to html files. It may keep the variables when export to Org (ox-org). Since both image link and file link are links, from

[FR] Should we resolve environment variables in the file link path when exporting? (was: [FR] Please add environment variable substitution in `org-display-inline-images')

2023-06-01 Thread Ihor Radchenko
Pan Xie writes: > Fantastic!! Thanks for your help. I can remove my ugly override codes. > > BTW, Please keep in mind that the org export codes also need to > substitute the environment variables. My proposal only works for the org > file itself, When exports the org file to html, the image fil