Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-19 Thread Nicolas Goaziou
Hello, "L.C. Karssen" writes: > I saw you changed a couple of things in the ODT exporter code recently. > I installed version (9.1.14-9-g131531-elpa today to see if those > commits This is not git HEAD, only the latest stable release. Could you try development version instead? Regards, --

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-19 Thread L.C. Karssen
Dear Nicolas, I saw you changed a couple of things in the ODT exporter code recently. I installed version (9.1.14-9-g131531-elpa today to see if those commits fixed the issue(s) discussed in this thread. However, exporting to ODT with a quoted template file name (#+ODT_STYLES_FILE) still doesn't

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-10 Thread Nicolas Goaziou
Hello, "L.C. Karssen" writes: > Taking the risk that the manual is lagging behind the actual code, I see > the following: > > #+ODT_STYLES_FILE:uses quotes > > #+INCLUDE:uses quotes > #+TEXINFO_FILENAME: doesn't use quotes [1] > > #+SETUPFILE: no example in the manual

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-07 Thread L.C. Karssen
Thanks for digging into this Christian. My lisp skills are quite undeveloped, so I can't really comment on the code. I had a look at the manual and I think we should go for a solution that is consistent for #+ keywords that have a filename argument like #+INCLUDE:, #+SETUPFILE and

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-07 Thread Christian Moe
Nicolas, Lennart, cc: Charles Celerier, Below, Lennart points out another issue with ODT_STYLES_FILE, a silent change in syntax not reflected in the manual: quotation marks are no longer needed around simple file paths. I think this change was introduced by the below commit, which stopped

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-06 Thread L.C. Karssen
On 06-11-18 16:35, Christian Moe wrote: > > I believe the need to use quotation marks around the style file name was > removed at some point I didn't know that. I had a quick look at the changes to ox-odt.el for the last few months, but it doesn't seem to be mentioned in any of the commit

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-06 Thread Christian Moe
I believe the need to use quotation marks around the style file name was removed at some point, and the manual is out of date. Instead of #+ODT_STYLES_FILE: "template.ott" the manual ought now to read: #+ODT_STYLES_FILE: template.ott Yours, Christian L.C. Karssen writes: > Hi list, > >

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-06 Thread L.C. Karssen
Hi list, Not sure if this is related (or fixed with the aforementioned patch) because I'm not using a list for the ODT style file. Today, after upgrading from Org 9.1.13 (actually installed from melpa on 20180625) to melpa version 20181105 exporting to ODT stopped working. In my org file the

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-05 Thread Christian Moe
Thanks, Nicolas! I'll test on my end when it shows up in ELPA. Yours, Christian Nicolas Goaziou writes: > Hello, > > Christian Moe writes: > >> It seems the ODT exporter currently fails to read the ODT_STYLES_FILE >> option as a list, as in this example from the manual >>

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-11-04 Thread Nicolas Goaziou
Hello, Christian Moe writes: > It seems the ODT exporter currently fails to read the ODT_STYLES_FILE > option as a list, as in this example from the manual > ([[info:org#Applying custom styles]]): > > #+ODT_STYLES_FILE: ("/path/to/file.ott" ("styles.xml" "image/hdr.png")) > > This is needed

Re: [O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-10-30 Thread Christian Moe
Sorry, forgot to attach the test files. #+title: ODT styles test #+ODT_STYLES_FILE: ("odt-test-styles.odt" ("styles.xml" "Pictures/120100A200B0A7D655E3F0A97ECF.png")) Place this Org file in the same directory as the accompanying file odt-test-styles.odt and export it to ODT.

[O] [BUG][ODT] ODT_STYLES_FILE not read as a list

2018-10-30 Thread Christian Moe
Hi, It seems the ODT exporter currently fails to read the ODT_STYLES_FILE option as a list, as in this example from the manual ([[info:org#Applying custom styles]]): #+ODT_STYLES_FILE: ("/path/to/file.ott" ("styles.xml" "image/hdr.png")) This is needed if you want a complex style with e.g. an