Fantastic,
I will apply this as soon as your FSF attribution goes through.
Speaking of has there been any progress on that front?
Thanks -- Eric
Litvinov Sergey writes:
>> In other words, replacing (or var "nil") with var would be enough
>
> Thanks. Fixed in the patch below. The patch also add
> In other words, replacing (or var "nil") with var would be enough
Thanks. Fixed in the patch below. The patch also adds an ert test.
>From b4b679abdc7bec9f3033b50f81d567a0bb48b147 Mon Sep 17 00:00:00 2001
From: Litvinov Sergey
Date: Sat, 1 Oct 2011 13:37:56 +0200
Subject: [PATCH 2/2] Remove red
Hello,
Litvinov Sergey writes:
> +(cond
> + ((stringp var)
> + (format "\'%s\'" (or var "nil")))
> + (t
> + (format "%s" (or var "nil"))
Just nitpicking:
In the first case, var is already identified as a string, so it will
always be non-nil, and your "or" is useless.
Please consider a tiny patch to add a string input variable to
ob-octave. I also add tests for ob-octave.
>From 4848960cefc1b1486705f7aed022ba199189b6e1 Mon Sep 17 00:00:00 2001
From: Litvinov Sergey
Date: Sat, 1 Oct 2011 02:04:49 +0200
Subject: [PATCH] Add string input variables to ob-octave.el.
