Re: [O] [PATCH] Add `org-reverse-string'

2013-02-13 Thread Bastien
Hi Daimrod, Daimrod writes: > Eric Schulte writes: > >> This patch looks fine to me, although you'll need to add a >> `declare-function' call to the top of ob-core.el (and maybe to org-id as >> well) or the compiler will complain. > > I've added a `declare-function' call to `ob-core.el' but I t

Re: [O] [PATCH] Add `org-reverse-string'

2013-01-26 Thread Daimrod
Eric Schulte writes: > This patch looks fine to me, although you'll need to add a > `declare-function' call to the top of ob-core.el (and maybe to org-id as > well) or the compiler will complain. I've added a `declare-function' call to `ob-core.el' but I think I don't need to add it to `org-id.e

Re: [O] [PATCH] Add `org-reverse-string'

2013-01-26 Thread Eric Schulte
This patch looks fine to me, although you'll need to add a `declare-function' call to the top of ob-core.el (and maybe to org-id as well) or the compiler will complain. Daimrod writes: > I needed a `reverse-string' function and I've found two in Org Mode. > `org-babel-reverse-string' and `org-id

[O] [PATCH] Add `org-reverse-string'

2013-01-26 Thread Daimrod
I needed a `reverse-string' function and I've found two in Org Mode. `org-babel-reverse-string' and `org-id-reverse-string'. So instead of rolling my own (I'm playing with `org-contacts.el'), I think it would be better to unify those functions into one. From e058c4fac767a5faffd8debaabc489c174eef58