Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-09-20 Thread Steven Rémot
Hello, Thomas S. Dye writes : If you'd like to contribute other patches, then you'll want to sign the FSF papers following the instructions here: http://orgmode.org/worg/org-contribute.html#sec-2 This process will probably take some weeks to complete. I completed the copyright assignment

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-09-20 Thread Nicolas Goaziou
Hello, Steven Rémot steven.re...@gmail.com writes: This patch adds support for :dbhost, :dbuser and :database parameters for SQL code blocks that uses postgresql engine. This allows to abstract postgresql login details instead of sending parameters in a psql-specific format using :cmdline

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-09-20 Thread Steven Rémot
Thank you for your comments. I attached the fixed patch below. On 09/20/2014 14:16, Nicolas Goaziou wrote: This is not related to your patch, but while you're at it, use `delq' instead of `remq' (nitpick) and `dbstring-postgresql' needs to be renamed `org-babel-sql-dbstring-postgresql' or some

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-09-20 Thread Nicolas Goaziou
Steven Rémot steven.re...@gmail.com writes: Thank you for your comments. I attached the fixed patch below. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-08-09 Thread Steven Rémot
Le 09/08/2014 02:38, Thomas S. Dye a écrit : Aloha Steven, Steven Rémot steven.re...@gmail.com writes: Hi, I did some changes to support :dbname, :dbhost and :database in SQL code blocks when using postgresql engine. Even if it was possible to specify this information using :cmdline

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-08-09 Thread Thomas S. Dye
Steven Rémot steven.re...@gmail.com writes: This is my only contribution to Emacs code, and it changes only 12 lines that impact a very tiny fragment of org, so I though I could send it without signing papers. If I was wrong, I don't mind signing papers at all. Either way should work. If

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-08-09 Thread Steven Rémot
Le 09/08/2014 17:31, Thomas S. Dye a écrit : If you'd like to contribute other patches, then you'll want to sign the FSF papers following the instructions here: I think it won't be the only patch I send to Org mode or Emacs, so I will sign copyright assignment and come back when it is done.

[O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-08-08 Thread Steven Rémot
Hi, I did some changes to support :dbname, :dbhost and :database in SQL code blocks when using postgresql engine. Even if it was possible to specify this information using :cmdline parameter, I thought it was a bit cleaner to be able to provide this information in a way independent from the

Re: [O] [PATCH] Add support for :dbhost, :dbuser and :database parameters for poastgresql in ob-sql.el

2014-08-08 Thread Thomas S. Dye
Aloha Steven, Steven Rémot steven.re...@gmail.com writes: Hi, I did some changes to support :dbname, :dbhost and :database in SQL code blocks when using postgresql engine. Even if it was possible to specify this information using :cmdline parameter, I thought it was a bit cleaner to be