Re: [O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item

2012-04-20 Thread Bastien
Hi Madan, Madan Ramakrishnan madan...@gmail.com writes: * lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional as advertised by the function applied, thanks. This is my first patch for org so apologies for any inadvertent missteps This is good, but please use plain text

Re: [O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item

2012-04-16 Thread Nick Dokos
Madan Ramakrishnan madan...@gmail.com wrote: * lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional as advertised by the function Problem here was that org-agenda-bulk-toggle calls org-agenda-bulk-mark with no parameters; however, the (max arg 1) call inside

Re: [O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item

2012-04-16 Thread Madan Ramakrishnan
Hi Nick, Ah, of course, you're right; it would result in a change in behavior. While I can certainly tweak the patch to maintain the old behavior in the case of a negative or zero arg, stepping back, I don't quite understand the reasoning for the current behavior. If a user has gone to the

Re: [O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item

2012-04-16 Thread Nick Dokos
Madan Ramakrishnan madan...@gmail.com wrote: Hi Nick,   Ah, of course, you're right; it would result in a change in behavior.     While I can certainly tweak the patch to maintain the old behavior in the case of a negative or zero arg, stepping back, I don't quite understand the reasoning

[O] [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at already marked item

2012-04-15 Thread Madan Ramakrishnan
* lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional as advertised by the function Problem here was that org-agenda-bulk-toggle calls org-agenda-bulk-mark with no parameters; however, the (max arg 1) call inside org-agenda-bulk-mark will fail with no parameter. Change the max to