Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-10-15 Thread Nick Dokos
Nicolas Goaziou writes: >> IIUC, this issue has not been sorted out yet. Should I wait for that to >> happen, >> or change the patch to use (apply #'nconc ...) and possibly revisit it in >> the >> future? > > I think the latter is fine. There are plenty of places to revisit in the > future an

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-10-15 Thread Nick Dokos
Nicolas Goaziou writes: > Hello, > > Nick Dokos writes: > >> IIUC, this issue has not been sorted out yet. Should I wait for that to >> happen, >> or change the patch to use (apply #'nconc ...) and possibly revisit it in >> the >> future? > > I think the latter is fine. There are plenty of p

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-10-07 Thread Nicolas Goaziou
Hello, Nick Dokos writes: > IIUC, this issue has not been sorted out yet. Should I wait for that to > happen, > or change the patch to use (apply #'nconc ...) and possibly revisit it in the > future? I think the latter is fine. There are plenty of places to revisit in the future anyway. Than

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-10-06 Thread Nick Dokos
Nicolas Goaziou nicolasgoaziou.fr> writes: > > Rasmus gmx.us> writes: > > > Nick Dokos gmail.com> writes: > > > >> I did a mapcan originally and saw that it was an alias for cl-mapcan in > >> cl-extras.el and that got me scared: ... > > > So cl-mapcan is OK. > > Actually it's not until Emac

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-08-17 Thread Nicolas Goaziou
Rasmus writes: > Nick Dokos writes: > >> I did a mapcan originally and saw that it was an alias for cl-mapcan in >> cl-extras.el and that got me scared: I vaguely recalled some rules about >> using cl-* stuff, but I don't really remember the rules any more. For >> future reference, are they writ

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-08-17 Thread Rasmus
Nick Dokos writes: > I did a mapcan originally and saw that it was an alias for cl-mapcan in > cl-extras.el and that got me scared: I vaguely recalled some rules about > using cl-* stuff, but I don't really remember the rules any more. For > future reference, are they written down somewhere? My

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-08-17 Thread Nick Dokos
Nicolas Goaziou writes: > Hello, > > Nick Dokos writes: > >> Here's a patch to add a new function to org-bbdb.el that provides early >> warning for upcoming anniversaries; it also adds some documentation to >> org.texi. > > Thank you. Some comments follow. > Thanks for the comments. Revised pat

Re: [O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-08-17 Thread Nicolas Goaziou
Hello, Nick Dokos writes: > Here's a patch to add a new function to org-bbdb.el that provides early > warning for upcoming anniversaries; it also adds some documentation to > org.texi. Thank you. Some comments follow. > +(defun org-bbdb-date-list (date n) > + "Return a list of dates in (m d y

[O] [PATCH] Allow early-warning anniversaries in agends [was: Re: org-bbdb-birthday reminder]

2015-08-16 Thread Nick Dokos
Julien Cubizolles writes: > Matt Lundin writes: > >> Nick Dokos writes: >> >>> Here's a quick implementation of the method I described earlier >>> in the thread: >> >> This works great. Thanks! Perhaps we could integrate something like this >> into org-bbdb.el... > > I second that. It's exactly