Bastien writes:
> Do you get difference results?
You're right after all. Since `org-capture-steal-local-variables'
isn't used anywhere else and since `org-capture' already set
`buffer-file-name' "manuall", I applied your change.
Thanks!
--
Bastien
Alex Kosorukoff writes:
> In fact, there is some performance issue.
This is what I observe (using elp-instrument-function on
`org-capture-steal-local-variables' and calling org-capture
10 times):
A: org-capture-steal-local-variables 10 0.005087601 0.0005087601
B: org-capture-steal-local-var
In fact, there is some performance issue. The steal function copies a lot
of variables as I can tell. Do you know where those variables are used? I
replaced the steal function with an advice like this
(defadvice org-capture-steal-local-variables (around do-not-steal activate))
My capture became v
Hi Alex,
Alex Kosorukoff writes:
> Excluding mark-active will work, the result will be the same as after
> my patch, except performance will not be the same. Excluding variable
> requires filtering the list of variables which takes O(n) whereas my
> patch takes O(1). Mark-active is nil before
>
On Fri, May 23, 2014 at 5:03 AM, Bastien wrote:
> Hi Alex,
>
> Alex Kosorukoff writes:
>
> > After I replaced my patch and merged Bastien's fix, I started seeing
> > the error though less frequently than before. It didn't occur in the
> > template I posted, but I started seeing it again in anoth
Hi Alex,
Alex Kosorukoff writes:
> After I replaced my patch and merged Bastien's fix, I started seeing
> the error though less frequently than before. It didn't occur in the
> template I posted, but I started seeing it again in another template.
>
> ("w" "org-protocol tag" entry (file "~/org/bo
After I replaced my patch and merged Bastien's fix, I started seeing the
error though less frequently than before. It didn't occur in the template I
posted, but I started seeing it again in another template.
("w" "org-protocol tag" entry (file "~/org/bookmarks.org")
"* %:description
Hi Alex,
Alex Kosorukoff writes:
> I noticed a regression in the capture functionality after upgrading
> org. Capture fails with error in subj
fixed, thanks,
--
Bastien
I noticed a regression in the capture functionality after upgrading org.
Capture fails with error in subj
Here is a simple config to reproduce the problem and a patch that fixes it.
emacs -q -l capfail.el
Best,
Alex
From ac50a5300e35d7abd5f50317069b2a795fde4ad8 Mon Sep 17 00:00:00 2001
From: Ale
