Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-31 Thread Nicolas Goaziou
Florian Beck f...@miszellen.de writes: Seems like this does trick. I don't really understand why, though.The previous profiling seemed to indicate that most of the time was spent in `org-entry-get' (that's why I removed it). `org-entry-get' is quite fast by itself. However it was called on

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-30 Thread Florian Beck
Hello, [sorry for the delay, I had some git SNAFUs] Could you also send and updated patch containing the VALUE optional argument to `org-re-property' and changing modifying only the (re ...) line in `org-find-property', with a new profiling? Seems like this does trick. I don't really

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-25 Thread Nicolas Goaziou
Florian Beck f...@miszellen.de writes: Could you profile it? Here are the results: With my setup and the patch I get, using (let ((time (current-time))) (org-id-find zangwill.nick_2014:aesthetic.judgment) (format %ss (time-to-seconds (time-subtract (current-time) time --

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-25 Thread Jacob Nielsen
I have this in one of my org files: # -*- cache-long-scans: nil; -*- # This makes forward-line much faster and thus org-goto-line and thus org-table-sum (C-c +) Does setting cache-long-scans to nil help in this case also ? Best, Jacob

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-24 Thread Florian Beck
Would you mind elaborating a bit? Slow down doing what? In which cases? A fraction of a second vs 10 seconds when executing a function that calls org-id-find. The slowdowwn is not quite as massive since I cleaned up org-id-files a bit, however. Could you profile it? I'll look into it.

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-24 Thread Florian Beck
Could you profile it? Here are the results: With my setup and the patch I get, using (let ((time (current-time))) (org-id-find zangwill.nick_2014:aesthetic.judgment) (format %ss (time-to-seconds (time-subtract (current-time) time -- 0.027756516s Without my patch, the result is --

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-24 Thread Sebastien Vauban
Nicolas Goaziou wrote: Florian Beck f...@miszellen.de writes: the recent changes in org-id (presumably 8cdb2eef0f9f98f9e00a5e689decfe341fe0c6ec) lead to a massive slowdown. Would you mind elaborating a bit? Slow down doing what? In which cases? Could you profile it? org-id-find is slow as

[O] [PATCH] Fix massive slowdown in org-id-find

2015-03-23 Thread Florian Beck
Hi, the recent changes in org-id (presumably 8cdb2eef0f9f98f9e00a5e689decfe341fe0c6ec) lead to a massive slowdown. org-id-find is slow as it is, now I find it almost unusable. Attached patch provides a fix. -- Florian Beck From 9867f0f45befc26854920d759a2505adba5d486b Mon Sep 17 00:00:00 2001

Re: [O] [PATCH] Fix massive slowdown in org-id-find

2015-03-23 Thread Nicolas Goaziou
Hello, Florian Beck f...@miszellen.de writes: the recent changes in org-id (presumably 8cdb2eef0f9f98f9e00a5e689decfe341fe0c6ec) lead to a massive slowdown. Would you mind elaborating a bit? Slow down doing what? In which cases? Could you profile it? org-id-find is slow as it is, now I find