Thanks.
--
Kaushal Modi
Kyle Meyer writes:
> Kaushal Modi writes:
>
>> Patch (after rebasing to 5a735b0) attached. I hope it works.
[...]
> I'll have another look at the changes tonight and will push it then
> unless there are more comments from me or others.
Pushed in ebacca39b, with a small change to protect an op
Kyle Meyer writes:
> Since in this case the branch only consists of one commit, you could
> also just make a new branch off of maint and cherry pick the commit from
> the original branch.
This was a misleading way for me to describe this. git cherry-pick has
accepted a range of commits since v1
Kaushal Modi writes:
> Patch (after rebasing to 5a735b0) attached. I hope it works.
Thanks. It almost works :)
Applying the patch fails because there's a whitespace change in one of
the context lines (the first one above the org-table-align change). You
should be able to see the same failure
Patch (after rebasing to 5a735b0) attached. I hope it works.
Git newbie question:
Making the changes in the maint version of these 4 files manually was a bit
of a pain. What's the right way of porting changes from one branch to
another? I am curious how the changes will be ported from the maint b
Kaushal Modi writes:
> About the patch not merging, I am surprised why that happened because I
> first rebased to
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=e69e18dd71bdf0c9bae9546bf026a1123b9a8c53
> and then created the patch. I redo the steps using git send-email tomorrow
> and under
I'll try to provide a working patch tomorrow. Yes, my FSF copyright
assignment is on file.
About the periods after commit descriptions, I will ensure that all
sentences other than the summary line end with a period.
About the patch not merging, I am surprised why that happened because I
first reb
Kaushal Modi writes:
> Below is now the latest patch = previous patch + help-echo straight quote
> fix.
Thanks for expanding this to the other cases. I'm not having any luck
getting this to apply to maint. Could you send it either as an
attachment or directly with git send-email?
> From a897b
On Thu, Mar 10, 2016 at 8:39 PM, Paul Eggert wrote:
> Help strings are considered documentation, so you need to escape special
> characters in help-echo property strings the same way you'd escape them in
> doc strings. Something like this:
>
> (let* ((str1 "\nhello")
>(echo-str1 "left sin
On 03/10/2016 09:47 AM, Kaushal Modi wrote:
How can I make the help-echo property display the ` and ' verbatim,
without curving them?
Help strings are considered documentation, so you need to escape special
characters in help-echo property strings the same way you'd escape them
in doc strin
Here's the updated patch (MINUS the help-echo fix):
>From 238ccdfc8bbdeb53196392a4dff96478a19cb5a5 Mon Sep 17 00:00:00 2001
From: Kaushal Modi
Date: Wed, 9 Mar 2016 01:18:58 -0500
Subject: [PATCH] Fix the single quote printed in the message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-
I am unable to figure out how to escape the ` and ' in the help-echo text
property.
I tried the below:
diff --git a/lisp/org-table.el b/lisp/org-table.el
index 0a25772..749baca 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -794,10 +794,10 @@ When nil, simply write \"#ERROR\" in corrup
Good point.
I will submit a new patch later today.
On Thursday, March 10, 2016, Kyle Meyer wrote:
> Kaushal Modi > writes:
>
> [...]
>
> > - (message
> > + (message "%s"
> > (substitute-command-keys "\\\
> > Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or
> > `\\[org-e
Kaushal Modi writes:
[...]
> - (message
> + (message "%s"
> (substitute-command-keys "\\\
> Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or
> `\\[org-edit-special]'. \
> See menu for more commands.")
There are a few other places in Org that call
"(message (substi
On 03/10/2016 07:33 AM, Kaushal Modi wrote:
Shouldn't this be handled by `substitute-command-keys' already?
The fix
looks like a hack.
I don't think this has anything to do with substitute-command-keys.
That function simply returns a string.
Right, 'message' and 'substitute-comm
Nicolas Goaziou writes:
>> Fix the quote style when in the "C-c '" key-binding that is printed in the
>> echo via the substitute-command-keys function. In emacs 25.x, a straight
>> quote is rendered as a right-curly quote by default.
>
> Shouldn't this be handled by `substitute-command-keys' alre
>
> Shouldn't this be handled by `substitute-command-keys' already? The fix
> looks like a hack.
I don't think this has anything to do with substitute-command-keys. That
function simply returns a string.
So the below 2 forms display the exact same thing: "C-c ’" (note the curved
right quote) by
Hello,
Kaushal Modi writes:
> Can someone please review and commit this patch.
>
> It basically prints the "C-c '" binding correctly in the echo area, using
> straight quote instead of curly quote (matters in emacs 25.x). The details
> are in the commit log below.
Thank you for the patch.
> Fi
Hi all,
Can someone please review and commit this patch.
It basically prints the "C-c '" binding correctly in the echo area, using
straight quote instead of curly quote (matters in emacs 25.x). The details
are in the commit log below.
>From f4411b59d8dc4e5b3df79ccbcd87f6bfe5160776 Mon Sep 17 00
19 matches
Mail list logo
