Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: >> Could you recreate the commit so it is self-contained? > > That should be it. Thank you. I applied your patch with the following changes: - I wrote a proper (according to our usage) commit message; - I slightly refactored the code;

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, Could you recreate the commit so it is self-contained? That should be it. Thanks, Fred >From e19c358f9d4cab9b22c3e4e3bf6b8f6298e61b0e Mon Sep 17 00:00:00 2001 From: Frederick Giasson Date: Fri, 18 Nov 2016 12:01:02 -0500 Subject: [PATCH] Multiple

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: > Hi Nicolas, >>In end of data: >>ob-clojure.el:180:1:Warning: the following functions are not known to be >>defined: nrepl-request:eval, nrepl--merge, nrepl-dict-put >> >> Could you look into it? In particular, "nrepl--merge"

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: > If I have to add it again, should I recreate the commit or simply > submit another patch? Could you recreate the commit so it is self-contained? Regards, -- Nicolas Goaziou

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Guys, It looks like this warning results from a defcustom for this variable not being included in the patch (and AFAICT it should be). Sorry but I was confused. The documentation for this setting was documented in Worg, but it was not yet part of the package. Here is the commit related

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, In end of data: ob-clojure.el:180:1:Warning: the following functions are not known to be defined: nrepl-request:eval, nrepl--merge, nrepl-dict-put Could you look into it? In particular, "nrepl--merge" looks like an internal function from nrepl. Is it safe to use it?

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi, It looks like this warning results from a defcustom for this variable not being included in the patch (and AFAICT it should be). Humm, I thought that it was already part of Org-mode 8.x (something I submitted a way back). Let me check that. If I have to add it again, should I recreate

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, hi all, 2016ko azaroak 17an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Frederick Giasson writes: > >> I am still waiting for FSF's signature. Should come in soon I guess. > > I applied your patch on a local branch, but compilation issues the > following

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: > I am still waiting for FSF's signature. Should come in soon I guess. I applied your patch on a local branch, but compilation issues the following warnings: In toplevel form: ob-clojure.el:86:1:Warning: Unused lexical variable

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, Great! Please let me know once the process is complete, so that I can apply your patch in master. I am still waiting for FSF's signature. Should come in soon I guess. Thanks, Fred

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: > I made all the changes requested and merged in a single commit. See > the attachment. Thank you. > I did as of today. Waiting to get a reply from them on that. Great! Please let me know once the process is complete, so that I can apply

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, Thank you. Some nit-picks follow. I made all the changes requested and merged in a single commit. See the attachment. BTW, did you sign FSF papers already? I cannot find any reference in org-contribute.org? I did as of today. Waiting to get a reply from them on that.

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: > No, what are the FSF papers? See . Since the patches no longer apply as tiny changes, we need these papers signed to move forward. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, I noticed that you included some of my previous fixes in Org-babel-clojure, so here are the latest work I did. I updated it to work with the latest code on Git. I did two things with these fixes: (1) I better handle any possible error or exceptions that may be raised by nREPL

Re: [O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hello, Frederick Giasson writes: > I noticed that you included some of my previous fixes in > Org-babel-clojure, so here are the latest work I did. I updated it to > work with the latest code on Git. I did two things with these fixes: > > > (1) I better handle any possible

[O] [PATCH] New header parameter :show-process for Org-babel-clojure

Hi Nicolas, The new Org-mode release 9.0 made me realize that I never finished some of my work with Org-babel-clojure. I noticed that you included some of my previous fixes in Org-babel-clojure, so here are the latest work I did. I updated it to work with the latest code on Git. I did two