Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-21 Thread Bastien
Nick Dokos nicholas.do...@hp.com writes: OTOH, if it happens to you once, you tend to remember it for ever after :-) Exactly -- and I think allowing to mean I'm a headline! would like to even more head-scratching/keyboard-throwing. -- Bastien

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-19 Thread Bastien
Hi, Nicolas Goaziou n.goaz...@gmail.com writes: * The regular expression matches completely empty headlines, so maybe the intention is to allow matching items with just a todo keyword? Yes, it is. FWIW I confirm it is. Note that I'm not convinced by empty headlines nor do I use

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-19 Thread Mats Kindahl
Thanks for clearing it up Bastien, Nicolas, do you have the patch somewhere so that I can take a look at it? Best wishes, Mats Kindahl On 09/19/2012 11:14 AM, Bastien wrote: Hi, Nicolas Goaziou n.goaz...@gmail.com writes: * The regular expression matches completely empty headlines, so

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-19 Thread Nicolas Goaziou
Hello, Mats Kindahl mats.kind...@oracle.com writes: Nicolas, do you have the patch somewhere so that I can take a look at it? The patch has been applied to master branch a few weeks ago. It's very simple: headline's text has been made optional. There's room from improvement, though: I find

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-19 Thread Bastien
Hi Nicolas, Nicolas Goaziou n.goaz...@gmail.com writes: There's room from improvement, though: I find strange that is a valid empty headline while isn't. This I find natural. The prefix for headlines includes the whitespace, so the whitespace is needed for empty headlines too.

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-19 Thread Nick Dokos
Bastien b...@altern.org wrote: Hi Nicolas, Nicolas Goaziou n.goaz...@gmail.com writes: There's room from improvement, though: I find strange that is a valid empty headline while isn't. This I find natural. The prefix for headlines includes the whitespace, so the

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-12 Thread Nicolas Goaziou
Hello, Well... the most important point for me is that it shouldn't choke on these lines, but otherwise I'm open to suggestions. In your case, I think that the problem really comes from a bad case matching: if SUBMITTED is a keyword, ** Submitted shouldn't be matched. IOW, todo keywords

[O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-10 Thread Mats Kindahl
Hi! I use org-mode quite a lot of most things and also have a number of workflows in my setup, use columnview quite a lot, and also have the habit of entering whatever text I need to write to resolve an issue under the item in org-mode format (quite convenient, then I can just export the subtree

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-10 Thread Nicolas Goaziou
Hello, Mats Kindahl mats.kind...@oracle.com writes: I solved this issue by requiring that there should always be a headline text (this is after all an assumption made in the code) and rewrote the org-complex-heading-regexp accordingly. Actually, I have recently committed a change going

Re: [O] [PATCH] Resolve regexp ambiguity for item headers

2012-09-10 Thread Mats Kindahl
On 09/10/2012 08:24 PM, Nicolas Goaziou wrote: Hello, Mats Kindahl mats.kind...@oracle.com writes: I solved this issue by requiring that there should always be a headline text (this is after all an assumption made in the code) and rewrote the org-complex-heading-regexp accordingly.