Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-14 Thread John Hendy
On Thu, Mar 13, 2014 at 3:17 AM, Bastien b...@gnu.org wrote: Hi John, John Hendy jw.he...@gmail.com writes: The trailing whitespace is the result of my texi ignorance. In a previous patch, Nicolas clarified that sentences needed to end in two spaces, and I add them at the end of my last

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-14 Thread Bastien
Hi John, thanks for the patch -- some comments below. John Hendy jw.he...@gmail.com writes: Header arguments: clarify that `:exports' is only applicable to blocks, not inline code This first line should include org.texi: to tell that the change happens in org.texi. See other commits for

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-14 Thread John Hendy
On Fri, Mar 14, 2014 at 10:51 AM, Bastien b...@altern.org wrote: Hi John, thanks for the patch -- some comments below. John Hendy jw.he...@gmail.com writes: Header arguments: clarify that `:exports' is only applicable to blocks, not inline code This first line should include org.texi: to

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-14 Thread Bastien
John Hendy jw.he...@gmail.com writes: No problem. I installed the patch in master, thanks. Last nitpick: I added a space in the change, as sentences in the manual should end with two spaces... sorry to repeat this :) -- Bastien

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-14 Thread John Hendy
On Fri, Mar 14, 2014 at 11:17 AM, Bastien b...@gnu.org wrote: John Hendy jw.he...@gmail.com writes: No problem. I installed the patch in master, thanks. Last nitpick: I added a space in the change, as sentences in the manual should end with two spaces... sorry to repeat this :) I caught

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-13 Thread Bastien
Hi John, John Hendy jw.he...@gmail.com writes: The trailing whitespace is the result of my texi ignorance. In a previous patch, Nicolas clarified that sentences needed to end in two spaces, and I add them at the end of my last sentence thinking they might be required to identify a new next

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-12 Thread Bastien
Hi John, John Hendy jw.he...@gmail.com writes: Feel free to counter my changes with suggestions/improvements and I'll re-submit. Looks good, except for the trailing whitespaces on a line. Can you resubmit this with a proper ChangeLog entry? Thanks! -- Bastien

Re: [O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-12 Thread John Hendy
Whoops, completely glossed over the ChangeLog bit of the patch submission guide. Sorry about that; I'll resubmit shortly. The trailing whitespace is the result of my texi ignorance. In a previous patch, Nicolas clarified that sentences needed to end in two spaces, and I add them at the end of my

[O] [PATCH] Update documentation for :exports (applicable to blocks only, not inline)

2014-03-11 Thread John Hendy
Per Eric's comment to a previous thread, I took a stab at updating two locations in the documentation that discuss using the :exports options so that users (like myself!) don't try to use them on inline code blocks. - http://lists.gnu.org/archive/html/emacs-orgmode/2014-03/msg00285.html Patch is