Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Bastien
Hi Ivan, Ivan Kanis ban...@kanis.fr writes: April, 28 at 10:59 Bastien wrote: Without your patch you should see that warntime is nil. Mhh... I don't see this. The call to (org-agenda) in your (progn...) will refresh the text-properties in foo.org and C-u C-x = show the property in both

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Ivan Kanis
Le 14 Mai à 10h36, Bastien a écrit : I tried it again on a more recent emacs (bzr from two weeks ago). Same result. Are you sure you removed your patch? :D Mhh... yes, I'm sure. Can anyone else reproduce Ivan's problem? Are you using bzr emacs? -- D'autres civilisations que la nôtre ont

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Bastien
Ivan Kanis ban...@kanis.fr writes: Le 14 Mai à 10h36, Bastien a écrit : I tried it again on a more recent emacs (bzr from two weeks ago). Same result. Are you sure you removed your patch? :D Mhh... yes, I'm sure. Can anyone else reproduce Ivan's problem? Are you using bzr emacs? Yes.

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Ivan Kanis
Le 14 Mai à 13h49, Bastien a écrit : Can anyone else reproduce Ivan's problem? Are you using bzr emacs? Now I recall it happens on 24.1 and bzr. Let's hope someone else can reproduce. -- La différence entre un bon et un mauvais architecte réside en ce que le mauvais succombe à toutes les

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Miguel Ruiz
--- El mar, 14/5/13, Ivan Kanis ban...@kanis.fr escribió: De: Ivan Kanis ban...@kanis.fr Asunto: Re: [O] [PATCH] fix appointment warn time Para: Bastien b...@gnu.org CC: org mode emacs-orgmode@gnu.org Fecha: martes, 14 de mayo, 2013 14:10 Le 14 Mai à 13h49, Bastien a écrit : Can

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Bastien
Hi Miguel, Miguel Ruiz rbeni...@yahoo.es writes: Yes, I can. Both Emacs 24.3 with Org-mode version 7.9.4 (7.9.4-1-ga5435f-elpa) and Org-mode version 8.0.2 (release_8.0.2-71-g5a1400) exhibits the problem than Ivan reports. For me it is solved with Bastien patch, i.e.

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Ivan Kanis
Le 14 Mai à 16h08, Bastien a écrit : Hi Miguel, Miguel Ruiz rbeni...@yahoo.es writes: Yes, I can. Both Emacs 24.3 with Org-mode version 7.9.4 (7.9.4-1-ga5435f-elpa) and Org-mode version 8.0.2 (release_8.0.2-71-g5a1400) exhibits the problem than Ivan reports. For me it is solved with

Re: [O] [PATCH] fix appointment warn time

2013-05-14 Thread Bastien
Ivan Kanis ban...@kanis.fr writes: Have you tried emacs -Q ? Yes... -- Bastien

Re: [O] [PATCH] fix appointment warn time

2013-04-28 Thread Ivan Kanis
April, 27 at 14:02 Bastien wrote: It works great and it looks less expensive. Thank you! Great -- thanks for testing this. Still, I need to really understand what real problem it fixes... is it because some of your functions needs to check the property or is it during regular use of Org?

Re: [O] [PATCH] fix appointment warn time

2013-04-28 Thread Bastien
Ivan Kanis ban...@kanis.fr writes: April, 27 at 14:02 Bastien wrote: It works great and it looks less expensive. Thank you! Great -- thanks for testing this. Still, I need to really understand what real problem it fixes... is it because some of your functions needs to check the property

Re: [O] [PATCH] fix appointment warn time

2013-04-28 Thread Ivan Kanis
April, 28 at 10:59 Bastien wrote: Without your patch you should see that warntime is nil. Mhh... I don't see this. The call to (org-agenda) in your (progn...) will refresh the text-properties in foo.org and C-u C-x = show the property in both the agenda and foo.org. I clearly miss

Re: [O] [PATCH] fix appointment warn time

2013-04-27 Thread Ivan Kanis
April, 26 at 19:01 Bastien wrote: The patch adds a function that goes at the beginning of the header to get the property. As a bonus it turns the string into a number. Please let me know if the patch is accepted or needs improvement. Can you try the attached patch instead? It works great

Re: [O] [PATCH] fix appointment warn time

2013-04-27 Thread Bastien
Ivan Kanis ban...@kanis.fr writes: April, 26 at 19:01 Bastien wrote: The patch adds a function that goes at the beginning of the header to get the property. As a bonus it turns the string into a number. Please let me know if the patch is accepted or needs improvement. Can you try the

[O] [PATCH] fix appointment warn time

2013-04-26 Thread Ivan Kanis
It seemed to be a boundary error. (point) was at the end of the timestamp which doesn't hold the org-appt-warntime property. foo.org illustrate what I have seen. Evaling the get-property sexp returns nil. The patch adds a function that goes at the beginning of the header to get the property. As

Re: [O] [PATCH] fix appointment warn time

2013-04-26 Thread Bastien
Hi Ivan, Ivan Kanis ban...@kanis.fr writes: It seemed to be a boundary error. (point) was at the end of the timestamp which doesn't hold the org-appt-warntime property. It does not hold the text property until this property has been set. E.g., `org-agenda-prepare-buffers' sets this property.