Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-04-17 Thread stardiviner
Stefano Rodighiero writes: > On Mon, Apr 15, 2019 at 6:11 PM Nicolas Goaziou > wrote: > > Thank you. I applied your patch. > > Great, thank you again for your help. > > Could you also provide an entry in ORG-NEWS? > > Attached. > > regards, > s. Now this patch is applied. I'm curious

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-04-17 Thread Nicolas Goaziou
Hello, Stefano Rodighiero writes: >> Could you also provide an entry in ORG-NEWS? >> > > Attached. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-04-15 Thread Stefano Rodighiero
On Mon, Apr 15, 2019 at 6:11 PM Nicolas Goaziou wrote: > Thank you. I applied your patch. > Great, thank you again for your help. > Could you also provide an entry in ORG-NEWS? > Attached. regards, s. -- www.stefanorodighiero.net From 802cbc9c8e631c4457934c4ad00b3c6ac2a62105 Mon Sep 17 00

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-04-15 Thread Nicolas Goaziou
Hello, Stefano Rodighiero writes: > I am attaching a new patch that should address your remarks. > Also, see comments below. Thank you. I applied your patch. Could you also provide an entry in ORG-NEWS? Regards, -- Nicolas Goaziou

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-04-14 Thread Stefano Rodighiero
On Sun, Apr 7, 2019 at 9:24 AM Nicolas Goaziou wrote: Thank you for your review. I am attaching a new patch that should address your remarks. Also, see comments below. > > +Given a param NAME, if :dbconnection is defined in PARAMS then > > +look for the param into the corresponding connection d

Re: [O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-04-07 Thread Nicolas Goaziou
Hello, Stefano Rodighiero writes: > [This is the first patch I ever submitted. Thank you. Some comments follow. > I hope it complies with > your standards: if it does not, I'll be happy to work on it until it's > fine. I am not sure it qualifies as a tiny change.] It does. > Subject: [PATCH

[O] [PATCH] ob-sql.el: Option to reference connections in `sql-connection-alist'

2019-03-24 Thread Stefano Rodighiero
Hi, [This is the first patch I ever submitted. I hope it complies with your standards: if it does not, I'll be happy to work on it until it's fine. I am not sure it qualifies as a tiny change.] Org-babel allows SQL snippets to be run on a database connection that can be specified in the source