Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello Nicolas, I saw my patch in the master for a while, but I still cannot get the change from `org-plus-contrib' package...I have to manually patch it on my local which is not very convenient. When could I expect my patch release in the `org-plus-contrib' package? Thanks, David On Mon, Jun 20

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Thanks Nicolas! I will consider to sign FSF the next time :) On Fri, Jun 17, 2016 at 6:29 AM Nicolas Goaziou wrote: > Hello, > > Xi Shen writes: > > > Please take a look at the updated patch. Changes: > > > > - add ORG-NEWS entry > > - add function declaration > > - add input file template for

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello, Xi Shen writes: > Please take a look at the updated patch. Changes: > > - add ORG-NEWS entry > - add function declaration > - add input file template for `mssql' engine to remove the "affected rows" > tail Applied. Thank you. Please consider signing FSF papers if you want to contribute

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

You can use sqsh to connect MS-sql too, more info you can see: https://github.com/tumashu/sql-mssql At 2016-06-16 14:04:26, "Xi Shen" wrote: Hi Nicolas, Please take a look at the updated patch. Changes: - add ORG-NEWS entry - add function declaration - add input file template for `mssql'

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi Nicolas, Please take a look at the updated patch. Changes: - add ORG-NEWS entry - add function declaration - add input file template for `mssql' engine to remove the "affected rows" tail On Thu, Jun 16, 2016 at 12:49 AM Nicolas Goaziou wrote: > Hello, > > Xi Shen writes: > > > I suppose I

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello, Xi Shen writes: > I suppose I should put the news entry to ./etc/ORG-NEWS file, but into > which version? I created below entry, please take look and let me know > where do you want me to put it. I'd say Version 9.0 > New features > Babel or Version 9.0 > Miscellaneous > *** Impr

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi Nicolas, I suppose I should put the news entry to ./etc/ORG-NEWS file, but into which version? I created below entry, please take look and let me know where do you want me to put it. *** Improved support to Microsoft SQL Server in =ob-sql.el= =ob-sql.el= library removes support to the ~msosql~

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi Nicholas, Sure, I will add the news and declaration. The "format" is required to quote the filename, so the spaces won't surprise sqlcmd. Maybe the arguments will be quoted when passing to the command? On Tue, Jun 14, 2016, 19:52 Nicolas Goaziou wrote: > Hello, > > Xi Shen writes: > > > I

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello, Xi Shen writes: > I think I uploaded the wrong patch. Sorry~ Please check this one. It looks good. Thank you. I have one minor comment about it, see below. Also, could you provide an entry for ORG-NEWS since this is a user visible change? > +(defun org-babel-sql-convert-standard-filena

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi Nicolas, I think I uploaded the wrong patch. Sorry~ Please check this one. On Mon, Jun 13, 2016 at 1:36 PM Xi Shen wrote: > Hi Nicolas, > > Please see my updated patch. > > > On Sun, Jun 12, 2016 at 6:37 PM Xi Shen wrote: > >> Hi Nicolas, >> >> So I will: >> >> - add "org-babel-sql-convert

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi Nicolas, Please see my updated patch. On Sun, Jun 12, 2016 at 6:37 PM Xi Shen wrote: > Hi Nicolas, > > So I will: > > - add "org-babel-sql-convert-filename", so another name...I am thinking > - remove `msosql` support. I am been playing with the options for a while, > and I could not find a

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi Nicolas, So I will: - add "org-babel-sql-convert-filename", so another name...I am thinking - remove `msosql` support. I am been playing with the options for a while, and I could not find a way the make osql output the same format as sqlcmd Thanks, David On Sun, Jun 12, 2016 at 10:12 AM Xi

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Yes, I think it is better to let upstream function to resolve the path for org-mode. But I have never contacted Emacs developers before. Should I go through the bug-gnu-em...@gnu.org mail list? Or there's a more effective channel? On Sat, Jun 11, 2016 at 4:41 PM Nicolas Goaziou wrote: > Hello,

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello, Xi Shen writes: > According to > https://www.gnu.org/software/emacs/manual/html_node/elisp/Standard-File-Names.html, > the `convert-standard-filename` works for *nix and MS-DOS, but not Cygwin > environment. And I tested, it does not work. For the prefix, please advice > me a better one.

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello Nicolas, Please see my replies inline. On Sat, Jun 11, 2016 at 6:06 AM Nicolas Goaziou wrote: > Hello, > > Xi Shen writes: > > > I would like to apply this path to add sqlcmd support, and allow org-mode > > to execute and capture sqlcmd output in cygwin environment. > > Thank you for the

Re: [O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hello, Xi Shen writes: > I would like to apply this path to add sqlcmd support, and allow org-mode > to execute and capture sqlcmd output in cygwin environment. Thank you for the patch. > I added a "platform-convert-file-name" function to convert a *nix path to > Windows path. Should I put thi

[O] [PATCH] ob-sql.el: Support sqlcmd and cygwin environment

Hi, I would like to apply this path to add sqlcmd support, and allow org-mode to execute and capture sqlcmd output in cygwin environment. I added a "platform-convert-file-name" function to convert a *nix path to Windows path. Should I put this function in ob-sql.el, or somewhere else? Thanks, D