Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-11 Thread Achim Gratz
Erik Hetzner writes: > Can you explain how this improves on what I had? The time spent appears to be > the same on my system (tested after clearing the filesystem cache): For users that are not using git-annex, it's doing exactly the same thing as before. The rest kicks in as long as git-annex ke

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-10 Thread Erik Hetzner
Hi Achim On Tue, 09 Feb 2016 14:19:25 -0800, Achim Gratz wrote: > > > […] > > Well, the best solution would be to have an option for git-annex to > switch off that lockdown thing. Since that's not going to happen soon > or anytime, try something like: > > $(RMR) $(testdir) || { $(CHMOD)

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-09 Thread Achim Gratz
Erik Hetzner writes: > Here are the permissions: > > 0755 /tmp/tmp-orgtest/ > 0700 /tmp/tmp-orgtest/org-annex-test19785b6F/ > 0775 /tmp/tmp-orgtest/org-annex-test19785b6F/.git/ > 0775 /tmp/tmp-orgtest/org-annex-test19785b6F/.git/annex/ > 0775 /tmp/tmp-orgtest/org-annex-test19785b6F/.git/annex/objec

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-09 Thread Erik Hetzner
Hi Achim, On Tue, 09 Feb 2016 11:40:54 -0800, Achim Gratz wrote: > > Erik Hetzner writes: > > Sorry - I misunderstood how `org-test-for-executable' works. I’ll fix the > > issue. > > Thanks. > > > As for the rm -rf, it does not work in the way you suggest, at least on > > ubuntu > > GNU/Linux.

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-09 Thread Achim Gratz
Erik Hetzner writes: > Sorry - I misunderstood how `org-test-for-executable' works. I’ll fix the > issue. Thanks. > As for the rm -rf, it does not work in the way you suggest, at least on ubuntu > GNU/Linux. Here is the result I get locally without the chmod: For pete's sake, what are the permi

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-08 Thread Erik Hetzner
On Sun, 07 Feb 2016 12:48:20 -0800, Achim Gratz wrote: > > Erik Hetzner writes: > > Thank you for all your feedback on this code! I’m really happy with how it > > turned out, and glad it is in master now. > > Please fix the tests to not fail (preferrably not run) if git-annex is > not installed.

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-07 Thread Achim Gratz
Erik Hetzner writes: > Thank you for all your feedback on this code! I’m really happy with how it > turned out, and glad it is in master now. Please fix the tests to not fail (preferrably not run) if git-annex is not installed. Also, revert the patch to mk/targets.mk; $(RMR) already includes the

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-07 Thread Erik Hetzner
Hi Rasmus and Kyle, On Sat, 06 Feb 2016 04:18:55 -0800, Rasmus wrote: > > Hi Erik and Kyle, > > Sorry for the delay, I was traveling this week. I’m happy with the patch now > and it has been pushed to master. Thank you for all your feedback on this code! I’m really happy with how it turned out,

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-06 Thread Rasmus
Hi Erik and Kyle, Sorry for the delay, I was traveling this week. I’m happy with the patch now and it has been pushed to master. Thanks! Rasmus -- Don't slow down Johnny, leave the Cadillac runnin'

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-04 Thread Kyle Meyer
Erik Hetzner writes: > From: Erik Hetzner > > * org-attach.el (org-attach-use-annex): New function to check if git > annex should be used. > (org-attach-annex-get-maybe): New function to get a file from git > annex if necessary. > (org-attach-annex-auto-get): New defcustom to determine b

[O] [PATCH] org-attach.el: Get attachments from git annex

2016-02-03 Thread Erik Hetzner
From: Erik Hetzner * org-attach.el (org-attach-use-annex): New function to check if git annex should be used. (org-attach-annex-get-maybe): New function to get a file from git annex if necessary. (org-attach-annex-auto-get): New defcustom to determine behavior of org-attach-annex-get-ma

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-01-31 Thread Erik Hetzner
Hi Rasmus, Thanks again for the feedback! On Wed, 27 Jan 2016 14:20:59 -0800, Rasmus wrote: > > Hi Erik, > > Thanks for the updated patch! > > A couple of more comments follow. > I hope I’m not being too annoying! Not at all, I appreciate it. > Erik Hetzner writes: > > > +(defcustom org-

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-01-28 Thread Kyle Meyer
Erik Hetzner writes: > I believe this addresses all the issues that have been raised. Thanks for all > your help with this. Thanks for the updates. I just have two minor things to add to Rasmus's comments. - Nitpick: It'd be nice if you could re-flow some of your lines to not be as wide. -

Re: [O] [PATCH] org-attach.el: Get attachments from git annex

2016-01-27 Thread Rasmus
Hi Erik, Thanks for the updated patch! A couple of more comments follow. I hope I’m not being too annoying! Erik Hetzner writes: > +(defcustom org-attach-annex-confirm-get-function #'y-or-n-p > + "Function to call to confirm if Org should call git annex get if necessary. > +If t, always get,

[O] [PATCH] org-attach.el: Get attachments from git annex

2016-01-26 Thread Erik Hetzner
* org-attach.el (org-attach-use-annex): New function to check if git annex should be used. (org-attach-annex-get-maybe): New function to get a file from git annex if necessary. (org-attach-annex-confirm-get-function): New defcustom to determine behavior of org-attach-annex-get-maybe. (o