Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-24 Thread Alexander Vorobiev
Thanks, I will try and see if it can be improved. Regards, Alex On Fri, Nov 22, 2013 at 3:54 AM, Bastien wrote: > Hi Alexander, > > Alexander Vorobiev writes: > > > The patch doesn't work unfortunately. I stepped through > > x-get-selection-value in w32-common-fns.el and the correct value fro

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-22 Thread Bastien
Hi Alexander, Alexander Vorobiev writes: > The patch doesn't work unfortunately. I stepped through > x-get-selection-value in w32-common-fns.el and the correct value from > the clipboard gets assigned to x-last-selected-text but then the > function just returns nil (line 120). I would say x-last

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-21 Thread Alexander Vorobiev
Hi Bastien, The patch doesn't work unfortunately. I stepped through x-get-selection-value in w32-common-fns.el and the correct value from the clipboard gets assigned to x-last-selected-text but then the function just returns nil (line 120). I would say x-last-selected text needs to be used somehow

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-19 Thread Bastien
Hi Alexander, can you test the attached patch and let me know if it works for you? Thanks, diff --git a/lisp/org-compat.el b/lisp/org-compat.el index b714f13..2eea724 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -350,7 +350,8 @@ Works on both Emacs and XEmacs." (or (x-get-s

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-18 Thread Alexander Vorobiev
I too was thinking of making the change to org-get-x-clipboard-compat instead, but somehow decided not to. It calls x-get-selection and the latter, while it does have w32-specific flavor (in w32-common-fns.el), doesn't seem to support clipboard and its primary purpose is stated as "Fix interface to

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-18 Thread Fabrice Popineau
Yes, you could lift the patch up to `org-get-x-clipboard-compat', but this way, òrg-no-properties' would be applied to the w32 data too. Is that relevant? I don't know if w32 clipboard data can have text properties. Fabrice 2013/11/18 Bastien > Hi Alexander, > > Alexander Vorobiev writes: > >

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-18 Thread Bastien
Hi Alexander, Alexander Vorobiev writes: > Sorry for the mis-formatting. Here is the patch as an attachment. Thanks -- digging into this again, maybe we need to fix `org-get-x-clipboard-compat' directly? I'm not using Windows so I can't test the patch. Can a Windows user help here? -- Bast

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-17 Thread Alexander Vorobiev
Hi Bastien, Sorry for the mis-formatting. Here is the patch as an attachment. Thanks, Alex On Sun, Nov 17, 2013 at 2:20 AM, Bastien wrote: > Hi Alexander, > > Alexander Vorobiev writes: > > > I noticed that %x capture template doesn't work under Windows which > > made my templates non-portab

Re: [O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-17 Thread Bastien
Hi Alexander, Alexander Vorobiev writes: > I noticed that %x capture template doesn't work under Windows which > made my templates non-portable, so I made this small change to > org-get-x-clipboard to fix that. This is my very first patch, please > let me know if it is acceptable. The patch loo

[O] [PATCH] org-compat: Support for getting data from Windows clipboard

2013-11-16 Thread Alexander Vorobiev
I noticed that %x capture template doesn't work under Windows which made my templates non-portable, so I made this small change to org-get-x-clipboard to fix that. This is my very first patch, please let me know if it is acceptable. Thanks, Alex * lisp/org-compat.el (org-get-x-clipboard): Use w32