Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

2013-06-09 Thread Nicolas Goaziou
Hello, Rasmus ras...@gmx.us writes: Nicolas Goaziou n.goaz...@gmail.com writes: It is, thank you. Here is another round of comments. v4 attached. Thank you. The patch looks good, but the feature needs to be documented. I think you could add a paragraph in `org-latex-classes' docstring,

Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

2013-06-07 Thread Nicolas Goaziou
Hello, Rasmus ras...@gmx.us writes: Nicolas Goaziou n.goaz...@gmail.com writes: is the attached patch better? It is, thank you. Here is another round of comments. + (replace-match (mapconcat 'identity + (if language +

Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

2013-06-07 Thread Rasmus
Nicolas Goaziou n.goaz...@gmail.com writes: Hello, Rasmus ras...@gmx.us writes: Nicolas Goaziou n.goaz...@gmail.com writes: is the attached patch better? It is, thank you. Here is another round of comments. +(replace-match (mapconcat 'identity + (if

Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

2013-06-07 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: Nicolas Goaziou n.goaz...@gmail.com writes: I suggest to use something like this instead: (mapconcat (lambda (option) (if (equal AUTO option) language option)) (cond ((member language options) (delete AUTO options)) ((member

Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

2013-06-07 Thread Rasmus
Nicolas Goaziou n.goaz...@gmail.com writes: It is, thank you. Here is another round of comments. v4 attached. -- C is for CookieFrom 2126f295e7137c1b90a8524108de4a7aaeac7e9f Mon Sep 17 00:00:00 2001 From: rasmus.pank rasmus.p...@gmail.com Date: Sat, 1 Jun 2013 00:20:18 +0200 Subject: [PATCH]

Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

2013-06-06 Thread Rasmus
Hi, Nicolas Goaziou n.goaz...@gmail.com writes: Thanks for your patch. Here are a few comments: is the attached patch better? It replaced AUTO with LANG when LANG is recognized and preserve position and LANG is the argument to LANGUAGE. I don't know if this patch uses the most efficient