Re: [O] [PATCH 07/10] Simplify org-babel-execute-src-block

2013-04-03 Thread Eric Schulte
Achim Gratz writes: > Eric Schulte writes: >> Can you check if this change causes any of the existing tests to fail? > > I don't think there is a test for that, at least I don't remember > anything in that direction. However when implementing my earlier change > w.r.t. confirmation I noticed tha

Re: [O] [PATCH 07/10] Simplify org-babel-execute-src-block

2013-04-03 Thread Achim Gratz
Eric Schulte writes: > Can you check if this change causes any of the existing tests to fail? I don't think there is a test for that, at least I don't remember anything in that direction. However when implementing my earlier change w.r.t. confirmation I noticed that merging the parameters early h

Re: [O] [PATCH 07/10] Simplify org-babel-execute-src-block

2013-04-03 Thread Eric Schulte
Achim Gratz writes: > Aaron Ecay writes: >> * lisp/ob-core.el (org-babel-execute-src-block): Simplify control flow >> >> Avoid potential duplication of org-babel-process-params call. Also >> makes the code simpler. > > You may be changing semantics here. I'm not entirely certain if the > curren

Re: [O] [PATCH 07/10] Simplify org-babel-execute-src-block

2013-04-02 Thread Achim Gratz
Aaron Ecay writes: > * lisp/ob-core.el (org-babel-execute-src-block): Simplify control flow > > Avoid potential duplication of org-babel-process-params call. Also > makes the code simpler. You may be changing semantics here. I'm not entirely certain if the current way of dealing with the the unm

[O] [PATCH 07/10] Simplify org-babel-execute-src-block

2013-03-31 Thread Aaron Ecay
* lisp/ob-core.el (org-babel-execute-src-block): Simplify control flow Avoid potential duplication of org-babel-process-params call. Also makes the code simpler. --- lisp/ob-core.el | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lisp/ob-core.el b/lisp/ob-core