Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Bernt Hansen
"Sebastien Vauban" writes: > Hi Bernt, > > Bernt Hansen wrote: >> Eeek! >> >> I'm not running into this (as far as I know) in my current setup but I >> vote we just revert the clocking restriction patches. There are other >> unresolved issues with these patches that I've seen and don't current

Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Bastien
"Sebastien Vauban" writes: > FYI, I have the (subjective) impression that the below bug just came up a > couple of days ago. I would say less than one calendar week. But I may be > wrong. Same here. -- Bastien

Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Sebastien Vauban
Hi Bernt, Bernt Hansen wrote: > Eeek! > > I'm not running into this (as far as I know) in my current setup but I > vote we just revert the clocking restriction patches. There are other > unresolved issues with these patches that I've seen and don't currently > have a fix for. > > Please revert th

Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Bernt Hansen
Correction to the commit SHA1s - 7a73e15 (Remove file restrictions when generating clock report data, 2012-01-09) - 8f93a75 (Honour existing restrictions when visiting tasks from the agenda, 2011-12-30) - c41a6f5 (Honour existing restrictions when clocking in from the agenda, 2011-12-30)

Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Bastien
Hi Bernt and Matt, Bernt Hansen writes: > Bastien/Carsten: > > Please revert the following commits (again). Sorry :( Done. Thanks, -- Bastien

Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Bernt Hansen
Eeek! I'm not running into this (as far as I know) in my current setup but I vote we just revert the clocking restriction patches. There are other unresolved issues with these patches that I've seen and don't currently have a fix for. - column view clocking totals on the agenda are wrong if a

Re: [O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2012-01-19 Thread Matt Lundin
Hi Bernt, Bernt Hansen writes: > * lisp/org-agenda.el (org-agenda-clock-in): Save restriction when clocking in > from the agenda > > Narrowed org buffers are now retained when clocking in from the agenda. > We only widen the buffer when the task to clock in is outside the existing > restriction

[O] [PATCH 2/3] Honour existing restrictions when clocking in from the agenda

2011-12-30 Thread Bernt Hansen
* lisp/org-agenda.el (org-agenda-clock-in): Save restriction when clocking in from the agenda Narrowed org buffers are now retained when clocking in from the agenda. We only widen the buffer when the task to clock in is outside the existing restriction. --- lisp/org-agenda.el | 17 +---