Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > On 2018-03-26 21:42, Nicolas Goaziou wrote: >> I'm talking about call_foo() syntax. I see no fundamental difference >> between (org-sbe-v2 "func" ...) and call_func(...). > > Sorry, how do you invoke call_func from lisp, or a table formula? I'm not sure there

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Bastien
Hello, Nicolas Goaziou writes: > Alan Schmitt writes: > >> On 2018-03-25 23:06, Nicolas Goaziou writes: >> >>> I have reverted your changes from maint. >> >> Should there be a new release? This change is present in 9.1.8. > > I /think/ I released Org 9.1.9, but I usually goof it up, so I'm Cc'

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Vladimir Panteleev
On 2018-03-26 21:42, Nicolas Goaziou wrote: I'm talking about call_foo() syntax. I see no fundamental difference between (org-sbe-v2 "func" ...) and call_func(...). Sorry, how do you invoke call_func from lisp, or a table formula? -- Best regards, Vladimir

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Nicolas Goaziou
Vladimir Panteleev writes: > By inline Babel calls, do you mean as described in > https://orgmode.org/manual/Evaluating-code-blocks.html ? I see there > "org-babel-execute-src-block", but it seems to attempt to infer the > src block to execute rather than letting the caller specify one. I'm talk

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Nicolas Goaziou
Hello, Alan Schmitt writes: > On 2018-03-25 23:06, Nicolas Goaziou writes: > >> I have reverted your changes from maint. > > Should there be a new release? This change is present in 9.1.8. I /think/ I released Org 9.1.9, but I usually goof it up, so I'm Cc'ing Bastien. Regards, -- Nicolas G

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Vladimir Panteleev
On 2018-03-26 20:16, Nicolas Goaziou wrote: Hello, Vladimir Panteleev writes: What about org-sbe is specific to tables? I'm thinking that the generic replacement could be used elsewhere, e.g.: (with-current-buffer some-org-mode-buffer (org-sbe-v2 "func" ...args...)) The generic replacem

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > Hi, > > On 2018-03-25 21:06, Nicolas Goaziou wrote: >> I agree "org-sbe" should be rewritten. However, it is specific to tables >> because it is meant to be used in a TBLFM line. Its replacement could >> live in "org-table.el", though. > > What about org-sbe i

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-26 Thread Alan Schmitt
On 2018-03-25 23:06, Nicolas Goaziou writes: > I have reverted your changes from maint. Should there be a new release? This change is present in 9.1.8. Best, Alan -- OpenPGP Key ID : 040D0A3B4ED2E5C7 Monthly Athmospheric CO₂, Mauna Loa Obs. 2018-02: 408.35, 2017-02: 406.42 signature.asc De

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-25 Thread Vladimir Panteleev
Hi, On 2018-03-25 21:06, Nicolas Goaziou wrote: I agree "org-sbe" should be rewritten. However, it is specific to tables because it is meant to be used in a TBLFM line. Its replacement could live in "org-table.el", though. What about org-sbe is specific to tables? I'm thinking that the generi

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-25 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > One ugly fix would be to patch over this by checking for some common > lisp forms that result in a list, such as (list ...) and (quote ...), > and treat the remaining ones in a backwards-compatible way. However, > the more time I spend on org-sbe, the more I t

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-25 Thread Vladimir Panteleev
On 2018-03-25 20:26, Nicolas Goaziou wrote: I think this has been applied to the maint branch, but I cannot find a mention of it in the ORG-NEWS file. Maybe it should be mentioned there as it is a breaking change. For instance,(I had to modify table formulas like Sorry, I did not intend this to

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-25 Thread Nicolas Goaziou
Hello, Alan Schmitt writes: > I think this has been applied to the maint branch, but I cannot find a > mention of it in the ORG-NEWS file. Maybe it should be mentioned there > as it is a breaking change. For instance,(I had to modify table formulas like > > #+TBLFM: @2$3..@>>$3='(org-sbe call_le

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-25 Thread Alan Schmitt
Hello, On 2018-03-20 00:07, Nicolas Goaziou writes: > Hello, > > Vladimir Panteleev writes: > >> OK, here is v2 with table-based tests. >> >> Vladimir Panteleev (3): >> ob-table: Fix org-sbe's handling of quotes in cell values >> ob-table: Fix org-sbe's handling of list arguments >> ob-ta

Re: [O] [PATCH v2 0/3] org-sbe fixes

2018-03-19 Thread Nicolas Goaziou
Hello, Vladimir Panteleev writes: > OK, here is v2 with table-based tests. > > Vladimir Panteleev (3): > ob-table: Fix org-sbe's handling of quotes in cell values > ob-table: Fix org-sbe's handling of list arguments > ob-table: Mention passing ranges as lists in org-sbe's documentation Ap

[O] [PATCH v2 0/3] org-sbe fixes

2018-03-18 Thread Vladimir Panteleev
OK, here is v2 with table-based tests. Vladimir Panteleev (3): ob-table: Fix org-sbe's handling of quotes in cell values ob-table: Fix org-sbe's handling of list arguments ob-table: Mention passing ranges as lists in org-sbe's documentation lisp/ob-table.el | 21 +-