Re: [O] [RFC] Change some defcustoms into defcont

2013-11-16 Thread Nicolas Goaziou
Hello, Carsten Dominik drostekirs...@gmail.com writes: So: IF YOU HAVE CUSTOMIZED any of this variables, I'd like to hear about it. Otherwise, I now think that the proposal is actually good and should move ahead. I applied the patch. Regards, -- Nicolas Goaziou

Re: [O] [RFC] Change some defcustoms into defcont

2013-11-16 Thread Carsten Dominik
On 16.11.2013, at 21:25, Nicolas Goaziou n.goaz...@gmail.com wrote: Hello, Carsten Dominik drostekirs...@gmail.com writes: So: IF YOU HAVE CUSTOMIZED any of this variables, I'd like to hear about it. Otherwise, I now think that the proposal is actually good and should move ahead. I

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-29 Thread Nicolas Goaziou
Hello, Carsten Dominik drostekirs...@gmail.com writes: So: IF YOU HAVE CUSTOMIZED any of this variables, I'd like to hear about it. Otherwise, I now think that the proposal is actually good and should move ahead. Here is the suggested patch. Regards, -- Nicolas Goaziou From

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-29 Thread Nicolas Goaziou
Correcting myself, Here is the suggested patch. I forgot `org-effort-property'. Also, the new version moves `org-latex-regexps' from defvar to defconst status. -- Nicolas Goaziou From d002525910b6fbeaec530138494bf43397be200b Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou n.goaz...@gmail.com

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-23 Thread Nicolas Goaziou
Hello, Carsten Dominik drostekirs...@gmail.com writes: can you remind me what the bug was? The taskjuggler issue? Correct. I will fix it today. Yes, as I said, I do see all these problems, but I also feel the responsibility to break as few as possible existing configurations. I

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-23 Thread Carsten Dominik
Hi Nicolas, and everyone else. I have just investigated what actually happens is someone has a customize setting for a variable in his/her setup, and then the variable is changed to a defconst behind his/her back. The result was very surprising to me: customize-set-variables still does set the

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-22 Thread Carsten Dominik
Dear Nicolas, On Oct 21, 2013, at 5:15 PM, Nicolas Goaziou n.goaz...@gmail.com wrote: Carsten Dominik carsten.domi...@gmail.com writes: The documentation of defconst says: Define SYMBOL as a constant variable. This declares that neither programs nor users should ever change the value.

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-22 Thread Nicolas Goaziou
Hello, You also said things like That's exactly the point of the defconst: you can still modify the variable, but it sends a strong message to the user. Also, it's not about deprecation: code base should still rely on these variables. so maybe I picked one interpretation over the other. I

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-22 Thread Carsten Dominik
On Oct 22, 2013, at 11:52 AM, Nicolas Goaziou n.goaz...@gmail.com wrote: Hello, You also said things like That's exactly the point of the defconst: you can still modify the variable, but it sends a strong message to the user. Also, it's not about deprecation: code base should still rely

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-22 Thread Torsten Wagner
Hi, not being a dev and really not being a lisp programmer, I still can see Nicolas attempt to unify the syntax in a way all and everyone/everything can rely on it. The question would be what would be more troublesome? Dealing in future with people who by chance changed some of those variables and

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-22 Thread Florian Beck
Torsten Wagner torsten.wag...@gmail.com writes: Anyhow, I just had this idea that org-mode could rely on a fixed (as written in stone) set of keywords and that an a new exporter backend will be introduced which simply creates a standard-conform org-mode file. Well, I like the idea of an

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-21 Thread Sebastien Vauban
Hello Nicolas, Nicolas Goaziou wrote: I'd like to suggest changing the following defcustom variables into defconst: - org-deadline-string - org-scheduled-string - org-closed-string - org-clock-string - org-comment-string - org-quote-string - org-effort-property -

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-21 Thread Nicolas Goaziou
Hello, Carsten Dominik carsten.domi...@gmail.com writes: I think this change breaks user setups. I don't know how many people do change these keywords, but I know some do, if only for localization purposes. I myself have modified the archive keyword in some cases, if I use this feature for

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-21 Thread Carsten Dominik
On 21.10.2013, at 10:56, Nicolas Goaziou n.goaz...@gmail.com wrote: Hello, Carsten Dominik carsten.domi...@gmail.com writes: I think this change breaks user setups. I don't know how many people do change these keywords, but I know some do, if only for localization purposes. I myself

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-21 Thread Nicolas Goaziou
Carsten Dominik carsten.domi...@gmail.com writes: On 21.10.2013, at 10:56, Nicolas Goaziou n.goaz...@gmail.com wrote: That's exactly the point of the defconst: you can still modify the variable, but it sends a strong message to the user. Also, it's not about deprecation: code base should

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-21 Thread Carsten Dominik
Hi Nicolas, On 21.10.2013, at 12:51, Nicolas Goaziou n.goaz...@gmail.com wrote: Carsten Dominik carsten.domi...@gmail.com writes: On 21.10.2013, at 10:56, Nicolas Goaziou n.goaz...@gmail.com wrote: That's exactly the point of the defconst: you can still modify the variable, but it sends

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-21 Thread Nicolas Goaziou
Carsten Dominik carsten.domi...@gmail.com writes: The documentation of defconst says: Define SYMBOL as a constant variable. This declares that neither programs nor users should ever change the value. This constancy is not actually enforced by Emacs Lisp, but SYMBOL is marked as a special

[O] [RFC] Change some defcustoms into defcont

2013-10-20 Thread Nicolas Goaziou
Hello, I'd like to suggest changing the following defcustom variables into defconst: - org-deadline-string - org-scheduled-string - org-closed-string - org-clock-string - org-comment-string - org-quote-string - org-effort-property - org-archive-tag There's no fundamental reason

Re: [O] [RFC] Change some defcustoms into defcont

2013-10-20 Thread Carsten Dominik
Hi Nicolas, I think this change breaks user setups. I don't know how many people do change these keywords, but I know some do, if only for localization purposes. I myself have modified the archive keyword in some cases, if I use this feature for a different purpose. You probably want to do