Re: [O] [babel][PATCHES] exporting inline source code

Hi Nicolas, thanks for implementing this. Nicolas Goaziou writes: > Nicolas Berthier writes: > >> Indeed. I fixed it in the new attached patch. Thanks. > > Applied. Thank you. Since the patch has been applied, I get a "Not at a block" error when finding some org-mode files -- I'll investiga

Re: [O] [babel][PATCHES] exporting inline source code

Hello, Nicolas Berthier writes: > Indeed. I fixed it in the new attached patch. Thanks. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [babel][PATCHES] exporting inline source code

Nicolas Goaziou wrote: > Hello, > > Nicolas Berthier writes: > >> In any case, as advised earlier in the discussion, I updated one patch >> to integrate new tests for the new feature. I also slightly simplified >> the HTML export patch to avoid useless display attributes. > > Thank you for this n

Re: [O] [babel][PATCHES] exporting inline source code

Hello, Achim Gratz writes: > Yes. But looking at the original regex has me wondering if the need for > the extra '[' isn't an indication of something more fundamentally wrong > with it. [^ \f\t\n\r\v] is wrong as character set allowed for languages should be much more limited than that. I disc

Re: [O] [babel][PATCHES] exporting inline source code

Nicolas Goaziou writes: >> + "\\(?:^\\|[^-[:alnum:]]\\)\\(src_\\([^ \f\t\n\r\v\\[]+\\)" > > I think "[^ \f\t\n\r\v[]" is enough. Yes. But looking at the original regex has me wondering if the need for the extra '[' isn't an indication of something more fundamentally wrong with it. Where does t

Re: [O] [babel][PATCHES] exporting inline source code

Hello, Nicolas Berthier writes: > In any case, as advised earlier in the discussion, I updated one patch > to integrate new tests for the new feature. I also slightly simplified > the HTML export patch to avoid useless display attributes. Thank you for this nice patch. Some comments follow. >

Re: [O] [babel][PATCHES] exporting inline source code

You wrote: > Hi Nicolas, > > Nicolas Berthier writes: > >> I will investigate on this ASAP, and notice you when I receive >> a confirmation that the FSF signed it. > > Thanks, we should expect longer delays during the summer I guess. Hi, I received the confirmation form the FSF today (should I

Re: [O] [babel][PATCHES] exporting inline source code

Hi Nicolas, Nicolas Berthier writes: > I will investigate on this ASAP, and notice you when I receive > a confirmation that the FSF signed it. Thanks, we should expect longer delays during the summer I guess. -- Bastien

Re: [O] [babel][PATCHES] exporting inline source code

You wrote: > Hi, > > Aaron Ecay writes: > >> Have you heard back from the FSF about your copyright assignment? > > This is more than 5 weeks since the patches were sent, so I hope the > FSF sent the papers. > > Nicolas, let us know so that we can move forward on this. > > Thanks, Hi, I have sig

Re: [O] [babel][PATCHES] exporting inline source code

Hi, Aaron Ecay writes: > Have you heard back from the FSF about your copyright assignment? This is more than 5 weeks since the patches were sent, so I hope the FSF sent the papers. Nicolas, let us know so that we can move forward on this. Thanks, -- Bastien

Re: [O] [babel][PATCHES] exporting inline source code

Hi Nicolas, These both seem like good patches to me. Did you run the test suite to make sure that no tests are broken by them? It would also be good if you added some tests for this functionality – the example included at the bottom of your email is a good starting point. The other babel export

[O] [babel][PATCHES] exporting inline source code

Hi, Please find attached two patches for review, related to the handling of inline source code. The first one enables babel to export pieces of inline source code as inline instead of as standard code blocks as it currently does. This is done by adding a new template (`org-babel-exp-inline-code-