Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Jambunathan K writes: >> we are discussing in abstract terms, and that might distract us from >> DTRT together: can you show the patched version of htmlfontify.el? > > Here you go. Thanks. I will look into this next week. Not before tuesday, as I'm off for a long week-end. Best, -- Bast

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Jambunathan K writes: >> +(defcustom org-export-odt-use-htmlfontify t The name of the variable is confusing -- we should mention this is about src block. >> + "Specify whether or not source blocks need to be fontified. >> +Turn this option on if you want to colorize the source code >> +blocks

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Jambunathan K writes: >> It just occurred to me: why using htmlfontify.el instead of >> htmlize.el? I guess there are good reasons... > > htmlfontify is part of Emacs and so a first class citizen. A user > doesn't have to install any additional package to get fontification > support. It will wor

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Jambunathan K
Jambunathan K writes: >> Hi Jambunathan, >> >> we are discussing in abstract terms, and that might distract us from >> DTRT together: can you show the patched version of htmlfontify.el? > > Here you go. > > Patch numbered 1 is the base htmlfontify.el (same as that in emacs-24 > trunk). I am also

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Jambunathan K
Bastien writes: > Hi Jambunathan, > > I see this addition in one of the latest commit: > > +(defcustom org-export-odt-use-htmlfontify t > + "Specify whether or not source blocks need to be fontified. > +Turn this option on if you want to colorize the source code > +blocks in the exported file.

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Jambunathan K
> It just occurred to me: why using htmlfontify.el instead of > htmlize.el? I guess there are good reasons... htmlfontify is part of Emacs and so a first class citizen. A user doesn't have to install any additional package to get fontification support. It will work out of the box. Jambunathan K

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Jambunathan K writes: > Till such time as this patch is integrated in to official Emacs, I would > like to check-in a copy of htmlfontify.el into the contrib dir. Will > there any objection to this? It just occurred to me: why using htmlfontify.el instead of htmlize.el? I guess there are good

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Hi Jambunathan, I see this addition in one of the latest commit: +(defcustom org-export-odt-use-htmlfontify t + "Specify whether or not source blocks need to be fontified. +Turn this option on if you want to colorize the source code +blocks in the exported file. For colorization to work, you ne

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Hi Jambunathan, we are discussing in abstract terms, and that might distract us from DTRT together: can you show the patched version of htmlfontify.el? Thanks! -- Bastien

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Jambunathan K
Based on my experience I have received far more feedback/bug reports on odt exporter since 7.6 release than when it was in my own git. All three suggestions made here miss the whole point. They are suggesting to hide a useful piece of work underneath githubs, repos etc. - It is not a question of

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-19 Thread Bastien
Hi Jambunathan, Jambunathan K writes: > I still need a way to save the changes. All I was asking for is some > temporary storage space. Okay -- org-mode/contrib/ is not the place for that, Achim's and Suvayu's suggestions are fine. Best, -- Bastien

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-18 Thread suvayu ali
On Thu, Aug 18, 2011 at 10:55 PM, Jambunathan K wrote: >>  Any user can add download the modified htmlfontify.el if he ever >> wants to achieve fonitification of source blocks in the odt file. > > If anyone is interested in fontification support they can drop a private > mail to me. I will be happ

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-18 Thread Jambunathan K
> Any user can add download the modified htmlfontify.el if he ever > wants to achieve fonitification of source blocks in the odt file. If anyone is interested in fontification support they can drop a private mail to me. I will be happy to share the modified htmlfontify.el. Jambunathan K. --

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-18 Thread Achim Gratz
> [1] This is more of a backup strategy than anything else. You can delete > the patches from the patchwork server if you want to. Your fork on repo.or.cz just needs another branch and you're good to go... no need to commit this to master and easily within reach. Regards, Achim. -- +<[Q+ Matrix

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-18 Thread Jambunathan K
>> Till such time as this patch is integrated in to official Emacs, I >> would like to check-in a copy of htmlfontify.el into the contrib >> dir. Will there any objection to this? > > Yes. We must avoid duplicate code as much as possible, especially > when the code lives in Elisp libraries that h

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-17 Thread Bastien
Hi Jambunathan, Jambunathan K writes: > I have patched up htmlfontify[1] to support fontification of odt > source blocks. The examples you sent look great! > I am planning to submit the patch to emacs-devel. The discussion will be more effective on emacs-orgmode mailing list, because most use

Re: [O] [odt] htmlfontify + Support for src blockfontification

2011-08-15 Thread suvayu ali
On Mon, Aug 15, 2011 at 10:36 PM, Jambunathan K wrote: > I am attaching sample before and after files to tickle the curiosity. > Amazing! -- Suvayu Open source is the future. It sets us free.

[O] [odt] htmlfontify + Support for src blockfontification

2011-08-15 Thread Jambunathan K
Bastien I have patched up htmlfontify[1] to support fontification of odt source blocks. I am planning to submit the patch to emacs-devel. Till such time as this patch is integrated in to official Emacs, I would like to check-in a copy of htmlfontify.el into the contrib dir. Will there any objec