Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

On Thu, Jun 15, 2017 at 8:40 AM Bastien Guerry wrote: > Kaushal Modi writes: > > > Before I commit this to master, I was thinking that this patch looks > > safe enough for the maint branch. If there are no objections, I can > > commit this to maint and

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

Kaushal Modi writes: > Before I commit this to master, I was thinking that this patch looks > safe enough for the maint branch. If there are no objections, I can > commit this to maint and merge to master. Sure, please go ahead. Thanks! -- Bastien

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

On Thu, Jun 15, 2017, 2:19 AM Bastien Guerry wrote: > Kaushal, thanks for the fix, please go > ahead and commit it. > Before I commit this to master, I was thinking that this patch looks safe enough for the maint branch. If there are no objections, I can commit this to maint and

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

Hi Paul, thanks for the follow-up -- Kaushal, thanks for the fix, please go ahead and commit it. Best, -- Bastien

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

On Thu, 15 Jun 2017, at 03:18 AM, Kaushal Modi wrote: > On Wed, Jun 14, 2017 at 1:02 PM Bastien Guerry wrote: > > > The question is: why this patch in the first place? Paul authored it > > and I committed it, so I should know--but I don't. Maybe Paul know or > > you know better?

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

On Wed, Jun 14, 2017 at 1:02 PM Bastien Guerry wrote: > The question is: why this patch in the first place? Paul authored it > and I committed it, so I should know--but I don't. Maybe Paul know or > you know better? > I later found the reason for that commit here:

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org

Hi Kaushal, thanks for putting me in the loop. Kaushal Modi writes: > I also find an org-invisible-p2 function, but it's not clear why it > does a (backward-char  1) before doing invisibility check.. and that > too eventually relies on outline-visible-p. (Turns out this

Re: [O] Backward incompatible outline-invisible-p change in emacs master for Org (Was: 6 failing tests on master branch)

On Wed, Jun 14, 2017 at 10:56 AM Kaushal Modi wrote: > One solution would be to have a new function "org-invisible-p" that > restores the old definition of outline-invisible-p. Interestingly I find > that an "org-invisible-p" did exist back then, but it was replaced with

[O] Backward incompatible outline-invisible-p change in emacs master for Org (Was: 6 failing tests on master branch)

On Thu, Jun 8, 2017 at 5:10 PM Nicolas Goaziou wrote: > > Test test-org/custom-properties condition: > > (ert-test-failed > > ((should > >(let > >(...) > > (org-test-with-temp-text "* H > > :PROPERTIES: > > :FOO: val > > :END: > > "