[O] Bug in org-log-into-drawer

2012-10-26 Thread Erik Hetzner
Hi, Current the org-log-into-drawer function does not honor the value of the LOG_INTO_DRAWER property if the property has the value nil. For example, if the org-log-into-drawer variable is set to t, but we have the file: * Foo :PROPERTIES: :LOG_INTO_DRAWER: nil :END: ** TODO Bar

Re: [O] Bug in org-log-into-drawer

2012-10-27 Thread Bastien
Hi Erik, thanks for the patch, I just applied it. Best, -- Bastien

Re: [O] Bug in org-log-into-drawer

2012-10-27 Thread Sebastien Vauban
Hello Erik, Erik Hetzner wrote: > Current the org-log-into-drawer function does not honor the value of > the LOG_INTO_DRAWER property if the property has the value nil. For > example, if the org-log-into-drawer variable is set to t, but we have > the file: > > * Foo > :PROPERTIES: > :LOG

Re: [O] Bug in org-log-into-drawer

2012-10-27 Thread Erik Hetzner
At Sat, 27 Oct 2012 11:00:40 +0200, Sebastien Vauban wrote: > > Hello Erik, > > I would have said that this does make sense, as the property LOG_INTO_DRAWER > is not inherited by the TODO entry, does it? > > See http://orgmode.org/manual/Property-inheritance.html for the few Org > properties for

Re: [O] Bug in org-log-into-drawer

2012-10-28 Thread Bastien
Hi Erik and Sébastien, Erik Hetzner writes: > The function org-log-into-drawer called the function org-entry-get > with the inherit argument before I got there. (Maybe it needs to be > added to that list?) I don't have time to look deeper in this issue. Can one of you have a closer look at the

Re: [O] Bug in org-log-into-drawer

2012-10-29 Thread Erik Hetzner
At Mon, 29 Oct 2012 06:41:39 +0100, Bastien wrote: > > Hi Erik and Sébastien, > > Erik Hetzner writes: > > > The function org-log-into-drawer called the function org-entry-get > > with the inherit argument before I got there. (Maybe it needs to be > > added to that list?) > > I don't have time

Re: [O] Bug in org-log-into-drawer

2012-10-29 Thread Sebastien Vauban
Hello Erik and Bastien, Erik Hetzner wrote: > Bastien wrote: >> Erik Hetzner writes: >> >>> The function org-log-into-drawer called the function org-entry-get with >>> the inherit argument before I got there. (Maybe it needs to be added to >>> that list?) >> >> I don't have time to look deeper

Re: [O] Bug in org-log-into-drawer

2012-10-29 Thread Erik Hetzner
At Mon, 29 Oct 2012 17:07:23 +0100, Sebastien Vauban wrote: > > Hello Erik and Bastien, > > […] > > I share your point... > > But do we all agree that your original example had to fail when > LOG_INTO_DRAWER is not inherited?[1] > > Or do I miss some point? > > Seb Hi Sebastien, Yes, I had a