Matt Lundin m...@imapmail.org writes:
Bastien b...@gnu.org writes:
I fixed the problem with `org-clock-state'. This should be `org-state'.
`state' is a local variable in many org.el functions, I renamed it to
`org-state' in org-clock.el and in caller sexp from org.el.
Attached please
Bastien b...@gnu.org writes:
I fixed the problem with `org-clock-state'. This should be `org-state'.
`state' is a local variable in many org.el functions, I renamed it to
`org-state' in org-clock.el and in caller sexp from org.el.
Attached please find a patch that fixes the docstring of
Achim Gratz strom...@nexgo.de writes:
Bastien writes:
1. one about `buffer-substring-filters'
We should write a compatibility function to get rid of the first
warning.
Actually it is a variable and it just needs to be aliased suitably,
depending on which Emacs version it encounters.
I'm
Bastien writes:
1. one about `buffer-substring-filters'
We should write a compatibility function to get rid of the first
warning.
Actually it is a variable and it just needs to be aliased suitably,
depending on which Emacs version it encounters. This should be done
with a macro in
Achim Gratz strom...@nexgo.de wrote:
Nick Dokos writes:
I assume that we are talking about the seven commits
Yes, but likely not all of them (or all changes in them). The only
problematic ones are where a dynamically scoped variable is renamed and
there are a bunch of others that
Nick Dokos nicholas.do...@hp.com writes:
There is (supposed to be) *one* place somewhere that actually defines
it:
(defvar foo 1)
... unless foo is dynamically bound into a caller sexp.
--
Bastien
Achim Gratz strom...@nexgo.de writes:
Bernt Hansen writes:
I can see the variable in the source defined as
lisp/org-clock.el:(defvar org-clock-state) ;; dynamically scoped into this
function
but I don't get a variable definition with this code in emacs 23.2.1.
You aren't supposed to get
Achim Gratz strom...@nexgo.de writes:
Bastien writes:
Well -- I'll be pretty busy next week, so hopefully we can fix this
soon... any help welcome! :)
Ditto, but you do realize this will be horribly broken in Emacs 24?
Achim Gratz strom...@nexgo.de writes:
Nick Dokos writes:
I assume that we are talking about the seven commits
Yes, but likely not all of them (or all changes in them). The only
problematic ones are where a dynamically scoped variable is renamed and
there are a bunch of others that probably
Hi Nick,
Nick Dokos nicholas.do...@hp.com writes:
Agreed, but the point is that each and every variable renaming will need
to be checked in the light of these criteria. Bugs like this have the
potential of creating havoc for a long time to come.
It may be easier to start from a working
Bastien writes:
Let's do some heavy testing against current HEAD and let's carefully
review code. But let's not panic -- Emacs is still in pretest, that's
the whole purpose of a pretest.
It looks like you've already took care of the fixes. Anything that you
specifically want to review?
Hi Achim,
Achim Gratz strom...@nexgo.de writes:
Bastien writes:
Let's do some heavy testing against current HEAD and let's carefully
review code. But let's not panic -- Emacs is still in pretest, that's
the whole purpose of a pretest.
It looks like you've already took care of the
Hi Bastien,
I updated to master today e917477 ((org-xhtml.el): Removed, 2012-04-01)
and am getting errors about org-clock-last-state not defined in my GNU
Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-12-11 on
raven, modified by Debian
I can see the variable in the source defined
Bernt Hansen writes:
I can see the variable in the source defined as
lisp/org-clock.el:(defvar org-clock-state) ;; dynamically scoped into this
function
but I don't get a variable definition with this code in emacs 23.2.1.
You aren't supposed to get one, as this should have been pulling in
Achim Gratz strom...@nexgo.de writes:
Again, the missing value is not the problem. The problem arises when
the variable name in the caller and the callee becomes different. I'll
let Bastien and Martyn sort that one out... :-)
Well -- I'll be pretty busy next week, so hopefully we can fix
Bernt Hansen be...@norang.ca wrote:
Hi Bastien,
I updated to master today e917477 ((org-xhtml.el): Removed, 2012-04-01)
and am getting errors about org-clock-last-state not defined in my GNU
Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-12-11 on
raven, modified by Debian
Nick Dokos nicholas.do...@hp.com writes:
Bernt Hansen be...@norang.ca wrote:
Hi Bastien,
I updated to master today e917477 ((org-xhtml.el): Removed, 2012-04-01)
and am getting errors about org-clock-last-state not defined in my GNU
Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of
Bastien writes:
Well -- I'll be pretty busy next week, so hopefully we can fix this
soon... any help welcome! :)
Ditto, but you do realize this will be horribly broken in Emacs 24?
Anyway, for that single dynamic state variable: it is let-bound in
org.el/org-todo and then dynamically scoped
Achim Gratz strom...@nexgo.de wrote:
Bastien writes:
Well -- I'll be pretty busy next week, so hopefully we can fix this
soon... any help welcome! :)
Ditto, but you do realize this will be horribly broken in Emacs 24?
Anyway, for that single dynamic state variable: it is let-bound in
Nick Dokos writes:
I assume that we are talking about the seven commits
Yes, but likely not all of them (or all changes in them). The only
problematic ones are where a dynamically scoped variable is renamed and
there are a bunch of others that probably are OK.
$ git log --oneline -100 | grep
20 matches
Mail list logo
