Re: [O] S-M-right problem in orgstruct-mode

2013-03-10 Thread Christopher Schmidt
Bastien writes: Hi there, > Alan Schmitt writes: > >> even though the cursor is on a structure element. Maybe a more >> information "this function is disabled" would work (if it's possible). >> But as I said, it's a nitpick. thank you very much for testing the patch. > I agree with Alan, let'

Re: [O] S-M-right problem in orgstruct-mode

2013-03-10 Thread Bastien
Hi Alan and Christopher, Alan Schmitt writes: > even though the cursor is on a structure element. Maybe a more > information "this function is disabled" would work (if it's possible). > But as I said, it's a nitpick. I agree with Alan, let's update the user-error to something more informative -

Re: [O] S-M-right problem in orgstruct-mode

2013-03-10 Thread Alan Schmitt
Christopher Schmidt writes: > Alan Schmitt writes: >> Looking at it there seems to be occurrences of '++' that are a bit >> strange. Was it garbled when attached? > > Ooops, I forgot to finalise my merge. It's looking good, thanks. One small nitpick: when a key is disabled, the message is orgst

Re: [O] S-M-right problem in orgstruct-mode

2013-03-09 Thread Christopher Schmidt
Alan Schmitt writes: > Looking at it there seems to be occurrences of '++' that are a bit > strange. Was it garbled when attached? Ooops, I forgot to finalise my merge. --- a/lisp/org.el +++ b/lisp/org.el @@ -8658,7 +8658,7 @@ If WITH-CASE is non-nil, the sorting will be case-sensitive." ;; comm

Re: [O] S-M-right problem in orgstruct-mode

2013-03-09 Thread Alan Schmitt
Christopher Schmidt writes: > Alan, here is patch for master that should solve the issue. It disables > org-{pr,de}mote and org-{,shift}meta{left,right} in orgstruct-mode iff > orgstruct-heading-prefix-regexp is non-nil. Could you please give it a > try and tell us what you think? Thanks a lot.

Re: [O] S-M-right problem in orgstruct-mode

2013-03-09 Thread Christopher Schmidt
Bastien writes: > Christopher Schmidt writes: >> ( In the long term this should be fixed properly. Considering that >> point is already on an actual headline, Org just needs to add or >> remove a star. This should not be too hard with >> org-heading-regexp. ) > > Beware that there are *ma

Re: [O] S-M-right problem in orgstruct-mode

2013-03-09 Thread Bastien
Hi Christopher, Christopher Schmidt writes: > I agree. I will come up with a patch ASAP. Thanks! > ( In the long term this should be fixed properly. Considering that > point is already on an actual headline, Org just needs to add or > remove a star. This should not be too hard with org-

Re: [O] S-M-right problem in orgstruct-mode

2013-03-09 Thread Christopher Schmidt
Bastien writes: > Alan Schmitt writes: > >> and do a shift-meta-right on the second line, I get: >> >> #+BEGIN_SRC emacs-lisp >> ;;; * Test 1 >> ** Test2 >> #+END_SRC > > I confirm this issue. > > The easiest thing to do is to prevent some commands to run when > `orgstruct-mode' is on and `or

Re: [O] S-M-right problem in orgstruct-mode

2013-03-09 Thread Bastien
Hi Alan, Alan Schmitt writes: > and do a shift-meta-right on the second line, I get: > > #+BEGIN_SRC emacs-lisp > ;;; * Test 1 > ** Test2 > #+END_SRC I confirm this issue. The easiest thing to do is to prevent some commands to run when `orgstruct-mode' is on and `orgstruct-heading-prefix-r

[O] S-M-right problem in orgstruct-mode

2013-03-08 Thread Alan Schmitt
Hello, I'm using a recently pulled orgmode from master. I have the following in an emacs-lisp buffer: #+BEGIN_SRC emacs-lisp ;; Local Variables: ;; eval: (orgstruct-mode 1) ;; orgstruct-heading-prefix-regexp: ";;; " ;; End: #+END_SRC With such local variables, if I start with: #+BEGIN_SRC emac

[O] S-M-right problem in orgstruct-mode

2013-03-08 Thread Alan Schmitt
Hello, I'm using a recently pulled orgmode from master. I have the following in an emacs-lisp buffer: #+BEGIN_SRC emacs-lisp ;; Local Variables: ;; eval: (orgstruct-mode 1) ;; orgstruct-heading-prefix-regexp: ";;; " ;; End: #+END_SRC With such local variables, if I start with: #+BEGIN_SRC emac