Re: [O] Suggested patch for org-agenda.el

2019-05-08 Thread Nicolas Goaziou
Hello, Stefan Monnier writes: > Misc changes: Thank you. > - Assume Emacs≥22 (we're using defvaralias already anyway). > - Try to make sure -function only contain functions (and never nil). > - Use define-minor-mode and define-derived-mode. > - Use command remapping. > - Initialize map from

[O] Suggested patch for org-agenda.el

2019-05-06 Thread Stefan Monnier
Misc changes: - Assume Emacs≥22 (we're using defvaralias already anyway). - Try to make sure -function only contain functions (and never nil). - Use define-minor-mode and define-derived-mode. - Use command remapping. - Initialize map from within its definition. - Use suppress-keymap. There'd be