[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-14 Thread Bastien
Daimrod daim...@gmail.com writes: In `org-fix-ellipsis-at-bol', the change wasn't : (save-excursion (set-window-start (selected-window) (window-start))) but : (save-excursion (set-window-start (selected-window) (point-min))) which is not a noop. But it does the wrong thing with isearch.

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-13 Thread Nicolas Richard
Bastien b...@gnu.org writes: I've now fixed this in the maint and master branch of Org's repository. Thanks for looking into it. Perhaps this isn't the right place to ask, but I wonder how (save-excursion (set-window-start (selected-window) (window-start))) isn't a noop. -- Nico.

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-13 Thread Bastien
Nicolas Richard theonewiththeevill...@yahoo.fr writes: Perhaps this isn't the right place to ask, but I wonder how (save-excursion (set-window-start (selected-window) (window-start))) isn't a noop. Perhaps it is a noop -- The purpose of `org-fix-ellipsis-at-bol' is to remove the ellipsis

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-13 Thread Daimrod
Bastien b...@gnu.org writes: Nicolas Richard theonewiththeevill...@yahoo.fr writes: Perhaps this isn't the right place to ask, but I wonder how (save-excursion (set-window-start (selected-window) (window-start))) isn't a noop. Perhaps it is a noop -- The purpose of

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-12 Thread Nicolas Richard
Daimrod daim...@gmail.com writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. Err, what's the rational behind this change? It is meant to

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-12 Thread Daimrod
Nicolas Richard theonewiththeevill...@yahoo.fr writes: Daimrod daim...@gmail.com writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I need to digg this further. Err,

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-12 Thread Daimrod
Daimrod daim...@gmail.com writes: Nicolas Richard theonewiththeevill...@yahoo.fr writes: Daimrod daim...@gmail.com writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org master branch, even with this fix. I

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-12 Thread Bastien
I've now fixed this in the maint and master branch of Org's repository. Firmly waiting for warnings from the CAR and CDR random checks! -- Bastien

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-12 Thread Daimrod
Daimrod daim...@gmail.com writes: Daimrod daim...@gmail.com writes: Nicolas Richard theonewiththeevill...@yahoo.fr writes: Daimrod daim...@gmail.com writes: PS: The change about throwing an error when recentering a window that does not display the current buffer breaks ~37 tests in Org

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-12 Thread Bastien
Daimrod daim...@gmail.com writes: I've read the fix in org-mode and I understand that it was a silly question. Please ignore it. Well, the whole thread gave me the guts to dive in and to find, as often, how tiny the challenge was -- so thanks for soft-prodding! -- Bastien

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-11 Thread Daimrod
Bastien b...@altern.org writes: Nicolas Richard theonewiththeevill...@yahoo.fr writes: David Griffiths dogriffi...@gmail.com writes: Debugger entered--Lisp error: (error `recenter'ing a window that does not display current-buffer.) recenter((4)) org-overview() So that's a duplicate of

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-11 Thread Stefan Monnier
+(defun org-recenter (optional arg) + Like `recenter' but ensure that the `current-buffer' is +properly set. + (with-current-buffer (window-buffer) +(recenter arg))) This doesn't make much sense: in many case (window-buffer) can be a buffer completely unrelated to Org.

[O] bug#17746: bug#17746: 24.4.50; byte-code: `recenter'ing a window that does not display current-buffer. when composing a message

2014-06-11 Thread Daimrod
Stefan Monnier monn...@iro.umontreal.ca writes: +(defun org-recenter (optional arg) + Like `recenter' but ensure that the `current-buffer' is +properly set. + (with-current-buffer (window-buffer) +(recenter arg))) This doesn't make much sense: in many case (window-buffer) can be a