Bastien Guerry writes:
> Kyle Meyer writes:
>
>>> Thanks for installing this -- Kyle, do you confirm you installed the
>>> change in Org's git repo?
>>
>> Yes, in a4edee4.
>
> Thanks!
And thank you everyone for fixing!
Phil
Kyle Meyer writes:
>> Thanks for installing this -- Kyle, do you confirm you installed the
>> change in Org's git repo?
>
> Yes, in a4edee4.
Thanks!
--
Bastien
Hi Stefan and Kyle,
Stefan Monnier writes:
>> No, I don't have commit rights. I'll update the Org side, but, for
>> issues that were introduced in the Emacs tree post 24.5, I don't know if
>> it's preferable to also update Emacs instead of waiting for the changes
>> to come over with a full syn
Bastien Guerry writes:
> Hi Stefan and Kyle,
>
> Stefan Monnier writes:
>
>>> No, I don't have commit rights. I'll update the Org side, but, for
>>> issues that were introduced in the Emacs tree post 24.5, I don't know if
>>> it's preferable to also update Emacs instead of waiting for the chang
> No, I don't have commit rights. I'll update the Org side, but, for
> issues that were introduced in the Emacs tree post 24.5, I don't know if
> it's preferable to also update Emacs instead of waiting for the changes
> to come over with a full sync.
Looks like there's no Org people following thi
Rasmus writes:
> Hi Phillip,
>
> Thanks for your report.
>
> phillip.l...@russet.org.uk (Phillip Lord) writes:
>
>> On emacs-25 ox-html, line 1847, org-html-fontify-code does this...
>>
>> (setq code (with-temp-buffer
>> ;; Switch to language-specific mode.
>>
Stefan Monnier writes:
>> Thank you. That seems to work nicely.
>> Is there anything else I need to do for the first patch?
>
> No, it's good to go. If you don't have commit rights, I can install it
> for you into emacs-25, unless the Org guys prefer to do it via the
> Org tree.
No, I don't ha
>> I see the problem. org-src-font-lock-fontify-block is using buffers
>> named " org-src-fontification:" in an unusual way:
>> they're updated via normal buffer modifications, but they're not put in
>> font-lock-mode, so all the font-lock machinery which tries to keep the
>> fontification up-to-d
Stefan Monnier writes:
[...]
> I see the problem. org-src-font-lock-fontify-block is using buffers
> named " org-src-fontification:" in an unusual way:
> they're updated via normal buffer modifications, but they're not put in
> font-lock-mode, so all the font-lock machinery which tries to keep
> Sure. With
>
> --8<---cut here---start->8---
>
> #+BEGIN_SRC elisp
> (require 'cl-lib)
> (message "test")
> #+END_SRC
> --8<---cut here---end--->8---
>
> in /tmp/scratch.org, run
>
> emacs -Q --eval "(setq org-src-font
Thanks for having a look.
Stefan Monnier writes:
>> (unless (eq major-mode lang-mode) (funcall lang-mode))
>> -(org-font-lock-ensure)
>> +;; Avoid `font-lock-ensure', which does not display fonts in
>> +;; source block.
>> +(font-lock-fontify-buffer)
> (defalias 'org-font-lock-ensure
> - (if (fboundp 'org-font-lock-ensure)
> + (if (fboundp 'font-lock-ensure)
>#'font-lock-ensure
> -(lambda (_beg _end) (font-lock-fontify-buffer
> +(lambda (&optional _beg _end) (font-lock-fontify-buffer
Looks good.
> (unless
phillip.l...@russet.org.uk (Phillip Lord) writes:
> Rasmus writes:
>>
>> Kyle Meyer writes:
>>
However, it's easy enough to switch to using an org-font-lock-ensure
variant that avoids these issues, so I will do that (in an updated
patch and on Org's maint).
>>>
>>> I've attached u
Rasmus writes:
>
> Kyle Meyer writes:
>
>>> However, it's easy enough to switch to using an org-font-lock-ensure
>>> variant that avoids these issues, so I will do that (in an updated
>>> patch and on Org's maint).
>>
>> I've attached updated patches against emacs-25. If these are applied to
>>
Hi Kyle,
Kyle Meyer writes:
>> I just have one concern, which is pretty theoretical. Isn’t it bad to
>> define the alias to be font-lock-ensure since this is an existing function
>> and people would have clear expectations of what they are calling? I
>> realize that there’s no Emacs-25 that wi
Kyle Meyer writes:
[...]
> However, it's easy enough to switch to using an org-font-lock-ensure
> variant that avoids these issues, so I will do that (in an updated
> patch and on Org's maint).
I've attached updated patches against emacs-25. If these are applied to
the Emacs repo, I'll backpor
Rasmus writes:
> Kyle Meyer writes:
[...]
>> The first patch replaces the font-lock-ensure compatibility alias from
>> 6711a21f1 with the one currently used in the Org repo (from commit
>> e6883dd03). The new alias is limited to being called with no
>> arguments, but, at the moment, no Org co
Kyle Meyer writes:
> Kyle Meyer writes:
>> Rasmus writes:
>>
>> [...]
>>
>>> Note, this change only lives it the Emacs version of Org. It was added in
>>> this commit:
>>>
>>>6711a21f1125c0047c56eb266eb374c1ec90a967
>
> [...]
>
>>
>> This commit was backported in Org commit d81e6b5, an
Kyle Meyer writes:
> I've attached two patches against emacs-25 that would get the Org and
> Emacs repos in similar states wrt font-lock-ensure.
Thanks Kyle.
> The first patch replaces the font-lock-ensure compatibility alias from
> 6711a21f1 with the one currently used in the Org repo (from co
Kyle Meyer writes:
> Rasmus writes:
>
> [...]
>
>> Note, this change only lives it the Emacs version of Org. It was added in
>> this commit:
>>
>>6711a21f1125c0047c56eb266eb374c1ec90a967
[...]
>
> This commit was backported in Org commit d81e6b5, and then followed up
> by c115c7b (org-
Hi Phillip and Rasmus,
Rasmus writes:
[...]
> Note, this change only lives it the Emacs version of Org. It was added in
> this commit:
>
>6711a21f1125c0047c56eb266eb374c1ec90a967
>Author: Stefan Monnier
>AuthorDate: Wed May 28 23:45:29 2014 -0400
>
> * lisp/f
phillip.l...@russet.org.uk (Phillip Lord) writes:
> Rasmus writes:
>
>> Hi Phillip,
>>
>> Thanks for your report.
>>
>> phillip.l...@russet.org.uk (Phillip Lord) writes:
>>
>>> On emacs-25 ox-html, line 1847, org-html-fontify-code does this...
>>>
>>> (setq code (with-temp-buffer
>>>
22 matches
Mail list logo