Re: [O] org-block-background in 8.3.1?

2015-08-20 Thread JI , Xiang
The thing is that while I could previously use variable-pitch-mode in the rest of org buffer and still let source code blocks inherit fixed-pitch face, now this seems to be impossible to achieve. With org-block-background face gone, even if I already set org-block face to inherit fixed-pitch, th

Re: [O] org-block-background in 8.3.1?

2015-08-19 Thread Bastien
Hi Sébastien, Sebastien Vauban writes: > That's why the very first step would (have) be(en) to put it as an > optional feature, that could been disabled by those who feel that it > introduces a performance delay -- what hasn't been shown so far IIRC. Can you provide a patch and a test? The p

Re: [O] org-block-background in 8.3.1?

2015-08-19 Thread Sebastien Vauban
Hi Bastien, Bastien writes: > Sebastien Vauban writes: > >> Really, it has been removed because of a problem when ps-print'ing an >> Org buffer -- though the bug was to find in `ps-def.el' and not in >> Org, as reported by Stefan Monnier [1]. It should have been fixed >> there instead. > > Yes, i

Re: [O] org-block-background in 8.3.1?

2015-08-18 Thread Bastien
Hi Sébastien, Sebastien Vauban writes: > Really, it has been removed because of a problem when ps-print'ing an > Org buffer -- though the bug was to find in `ps-def.el' and not in Org, > as reported by Stefan Monnier [1]. It should have been fixed there > instead. Yes, indeed. >> I'm not aw

Re: [O] org-block-background in 8.3.1?

2015-08-12 Thread Kyle Meyer
Sebastien Vauban writes: > Kyle Meyer writes: >> org-block-background was removed in f8b42e8 ("Don't use an overlay for >> src blocks backgrounds", 2014-07-28) for performance reasons. > > IIRC, we never saw a profiler report showing that it slowed down buffer > fontification in a visible way. Cor

Re: [O] org-block-background in 8.3.1?

2015-08-12 Thread Sebastien Vauban
Kyle Meyer writes: > Luke Crook wrote: >> I'm not sure if I still need to set "org-block-background" in 8.3.1. >> >> But if I do need to continue setting this, what is the new name for "org- >> block-background"? >> >> (set-face-attribute 'org-block-background nil >> :height (

Re: [O] org-block-background in 8.3.1?

2015-08-11 Thread Kyle Meyer
Luke Crook wrote: > I'm not sure if I still need to set "org-block-background" in 8.3.1. > > But if I do need to continue setting this, what is the new name for "org- > block-background"? > > (set-face-attribute 'org-block-background nil > :height (round (* 0.9 (face-attribute

[O] org-block-background in 8.3.1?

2015-08-11 Thread Luke Crook
I'm not sure if I still need to set "org-block-background" in 8.3.1. But if I do need to continue setting this, what is the new name for "org- block-background"? (set-face-attribute 'org-block-background nil :height (round (* 0.9 (face-attribute 'fixed-pitch :height (s