Re: [O] org-player and switch to lexical binding in org.el

Hi Paul On Thu, Jan 28, 2016 at 4:00 AM, Paul Sexton wrote: > Hi, I have just pushed the suggested change to the org-player repository on > bitbucket. Please let me know if it has fixed the problem. org-player.el 1.0.1 plays again for links with a position. For links

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > My concern is only the version 9.1 which I find too early. A FIXME in > my sense is added to the attached patch, please rephrase if necessary. It looks good. Thank you. Regards, -- Nicolas Goaziou

Re: [O] org-player and switch to lexical binding in org.el

Hi Nicolas On Thu, Feb 4, 2016 at 9:36 AM, Nicolas Goaziou wrote: > I do not mind, as there is an explicit "FIXME" or "XXX" somewhere above > reminding us to remove this at some point. My concern is only the version 9.1 which I find too early. A FIXME in my sense is

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > I would prefer to keep it much longer for those who do not regularly > update Org. The many cases when Org 9.0 is not part of the update > path. E. g. when a distro will include Emacs 25.1 with Org 8.3.3 (?) > in some time and a user

Re: [O] org-player and switch to lexical binding in org.el

Hi Nicolas and Paul On Wed, Feb 3, 2016 at 6:33 PM, Nicolas Goaziou wrote: > I replaced S-expressions with functions of two arguments. The Org world > is a better place with one less `eval'. Just to confirm: Updating org-player.el to 1.0.1 makes Org links to media files

Re: [O] org-player and switch to lexical binding in org.el

Hi Nicolas On Wed, Feb 3, 2016 at 9:56 PM, Nicolas Goaziou wrote: > I have no objection, but I suggest to add a big fat FIXME above so as to > remove it once we release Org 9.1. I would prefer to keep it much longer for those who do not regularly update Org. The many

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > For all this I suggest a simple migration hint like the error in my > attached patch. Did I miss its disadvantage? I have no objection, but I suggest to add a big fat FIXME above so as to remove it once we release Org 9.1. Also, it

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > I see the pros and cons of either solution with a slight bias to not > break backward compatibility and am OK with what you and others > decide. I replaced S-expressions with functions of two arguments. The Org world is a better place

Re: [O] org-player and switch to lexical binding in org.el

Hi Nicolas and Paul On Sun, Jan 31, 2016 at 12:30 AM, Nicolas Goaziou wrote: > Michael Brand writes: > >> Only slowly I begin to get it partially. My observation is that if the >> current `org-open-file' would be changed to >> >> (eval

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > Only slowly I begin to get it partially. My observation is that if the > current `org-open-file' would be changed to > > (eval cmd > ;; LEXICAL argument. > `((file . ,(convert-standard-filename file)) >

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > On Sun, Jan 17, 2016 at 9:40 PM, Nicolas Goaziou > wrote: > >> In the current case, you need to use match string: >> >> (add-to-list 'org-file-apps >>(cons (concat

Re: [O] org-player and switch to lexical binding in org.el

Hi Nicolas On Fri, Jan 29, 2016 at 2:32 PM, Nicolas Goaziou wrote: > My suggestion was hypothetical, and not yet implemented. No wonder it > doesn't work. > > If you think this change sounds reasonable, I can implement it, tho. > However, there is some backward

Re: [O] org-player and switch to lexical binding in org.el

Hi Nicolas On Sun, Jan 17, 2016 at 9:40 PM, Nicolas Goaziou wrote: > Hello, > > Michael Brand writes: > >> release_8.3.3-426-g1f49e9f introduces a regression. The link >> >> [[file:/dir/audio.mp3::0:12:34]] >> >> results in >> >>

Re: [O] org-player and switch to lexical binding in org.el

Hi Paul It seems that this is beyond of my knowledge and I would like to ask you as the author of org-player for help. On Sun, Jan 17, 2016 at 9:40 PM, Nicolas Goaziou wrote: > Hello, > > Michael Brand writes: > >> release_8.3.3-426-g1f49e9f

[O] org-player and switch to lexical binding in org.el

Hi all release_8.3.3-426-g1f49e9f introduces a regression. The link [[file:/dir/audio.mp3::0:12:34]] results in Debugger entered--Lisp error: (void-variable search) (org-player-play-file file search) [...] org-open-file("/dir/audio.mp3" nil nil "0:12:34") [...]

Re: [O] org-player and switch to lexical binding in org.el

Hello, Michael Brand writes: > release_8.3.3-426-g1f49e9f introduces a regression. The link > > [[file:/dir/audio.mp3::0:12:34]] > > results in > > Debugger entered--Lisp error: (void-variable search) > (org-player-play-file file search) > [...] >

Re: [O] org-player and switch to lexical binding in org.el

Hi Paul It seems that this is beyond of my knowledge and I would like to ask you as the author of org-player for help. On Sun, Jan 17, 2016 at 9:40 PM, Nicolas Goaziou wrote: > Hello, > > Michael Brand writes: > >> release_8.3.3-426-g1f49e9f