Re: [Orgmode] Bug found (but don't know to fix)

2008-05-21 Thread Wanrong Lin
Yes, this works! Thank you. Wanrong Carsten Dominik wrote: On May 21, 2008, at 4:25 PM, Wanrong Lin wrote: Hi, Carsten, Thanks a lot for the patch. I tried it, but it does not work. I traced into the "org-open-at-point" function and found the patch is not executed because the condition *

Re: [Orgmode] Bug found (but don't know to fix)

2008-05-21 Thread Carsten Dominik
On May 21, 2008, at 4:25 PM, Wanrong Lin wrote: Hi, Carsten, Thanks a lot for the patch. I tried it, but it does not work. I traced into the "org-open-at-point" function and found the patch is not executed because the condition *"(stringp cmd)" *is not satisfied, as "cmd" is a list "(w32

Re: [Orgmode] Bug found (but don't know to fix)

2008-05-21 Thread Wanrong Lin
Hi, Carsten, Thanks a lot for the patch. I tried it, but it does not work. I traced into the "org-open-at-point" function and found the patch is not executed because the condition *"(stringp cmd)" *is not satisfied, as "cmd" is a list "(w32-shell-execute "open" file)". This function seems a l

Re: [Orgmode] Bug found (but don't know to fix)

2008-05-21 Thread Carsten Dominik
Hi Wanrong, how about the following patch: - Carsten diff --git a/lisp/org.el b/lisp/org.el index 9094204..ee1b923 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -7385,7 +7385,9 @@ If the file does not exist, an error is thrown." (setq cmd (replace-match "%s" t t cmd))) (while (st

[Orgmode] Bug found (but don't know to fix)

2008-05-19 Thread Wanrong Lin
Hi Carsten: I have observed that in Windows "org-open-at-point" (bound to RET key in my config) does not work on something like this: file:\\hostname\path Today I dug a little bit into it, and found the problem is here (in red): (defun org-open-file (path &optional in-emacs line search) "Op