Thanks Julien,
This patch format is better. Could you put the comments like 'I may
have done this badly, ...' and 'It works but there maybe some corners
case ...' after the --- and before the diffstat?
This isn't really useful to keep permanently in the org-mode history if
this patch is accepted
On Mon, Dec 13 2010, Bernt Hansen wrote:
> This patch format is better. Could you put the comments like 'I may
> have done this badly, ...' and 'It works but there maybe some corners
> case ...' after the --- and before the diffstat?
Sure, this is how I did usually, but last time I did that IIRC
Julien Danjou writes:
> On Tue, Dec 14 2010, Giovanni Ridolfi wrote:
>
>> I think that you can put some extra, useful, information, that can go
>> in the Changelog, as lines not beginning with "*".
>>
>> But if you write very unformal/personal comments like:
>> 'I may have done this badly, ...
Julien Danjou writes:
> On Mon, Dec 13 2010, Bernt Hansen wrote:
>
>> This patch format is better. Could you put the comments like 'I may
>> have done this badly, ...' and 'It works but there maybe some corners
>> case ...' after the --- and before the diffstat?
>
> Sure, this is how I did usual
On Tue, Dec 14 2010, Giovanni Ridolfi wrote:
> I think that you can put some extra, useful, information, that can go
> in the Changelog, as lines not beginning with "*".
>
> But if you write very unformal/personal comments like:
> 'I may have done this badly, ...' you should write after the ---
Julien Danjou wrote:
> On Tue, Dec 14 2010, Giovanni Ridolfi wrote:
>
> > I think that you can put some extra, useful, information, that can go
> > in the Changelog, as lines not beginning with "*".
> >
> > But if you write very unformal/personal comments like:
> > 'I may have done this badly
Hi Julien,
are you going to resend the patch? I do like the functionality!
Or did you already resend it? Maybe I missed it. Unfortunately
I am loosing my overview here.
Cheers
- Carsten
On Dec 14, 2010, at 11:30 AM, Julien Danjou wrote:
On Tue, Dec 14 2010, Giovanni Ridolfi wrote:
I thi
On Thu, Dec 16 2010, Carsten Dominik wrote:
> are you going to resend the patch? I do like the functionality!
> Or did you already resend it? Maybe I missed it. Unfortunately
> I am loosing my overview here.
If the code seems fine to you, I can resend the patch with a clean
commit message, for
Please do, thank you.
- Carsten
On Dec 16, 2010, at 2:45 PM, Julien Danjou wrote:
On Thu, Dec 16 2010, Carsten Dominik wrote:
are you going to resend the patch? I do like the functionality!
Or did you already resend it? Maybe I missed it. Unfortunately
I am loosing my overview here.
If
