Re: [Orgmode] org-mode CSS property export bug

2010-04-26 Thread Rick Moynihan
On 25 April 2010 13:08, Carsten Dominik wrote: > OK, it has been applied now, and I have re-published everything on > orgmode.org, including Worg, to make problems with this show up as quickly > as possible. > > Thanks! > > - Carsten Thanks for the quick fix on this! :-) org-mode rocks! R. _

Re: [Orgmode] org-mode CSS property export bug

2010-04-25 Thread Carsten Dominik
OK, it has been applied now, and I have re-published everything on orgmode.org, including Worg, to make problems with this show up as quickly as possible. Thanks! - Carsten On Apr 25, 2010, at 12:27 PM, Sebastian Rose wrote: Carsten, this looks all OK to me. Tested and works. Sebas

Re: [Orgmode] org-mode CSS property export bug

2010-04-25 Thread Sebastian Rose
Carsten, this looks all OK to me. Tested and works. Sebastian Carsten Dominik writes: > He Sebastian, > > I believe we need a bit more - here is my patch - can you please take a look? > Thanks! > > - Carsten > > Modified lisp/org-docbook.el > diff --git a/lisp/org-docbook.el b/lis

Re: [Orgmode] org-mode CSS property export bug

2010-04-24 Thread Carsten Dominik
He Sebastian, I believe we need a bit more - here is my patch - can you please take a look? Thanks! - Carsten Modified lisp/org-docbook.el diff --git a/lisp/org-docbook.el b/lisp/org-docbook.el index de9ffcc..bb8d048 100644 --- a/lisp/org-docbook.el +++ b/lisp/org-docbook.el @@ -1228

Re: [Orgmode] org-mode CSS property export bug

2010-04-24 Thread Sebastian Rose
Carsten Dominik writes: > Hi Sebastian, > > I need to ask: > > What exactly are we changing? just the class names? of the id and names as > well? Will links have to be changed? We are changing the values of the `id' attributes inside html tags. - in headlines ( and similar) - in the con

Re: [Orgmode] org-mode CSS property export bug

2010-04-24 Thread Carsten Dominik
Hi Sebastian, I need to ask: What exactly are we changing? just the class names? of the id and names as well? Will links have to be changed? - Carsten On Apr 24, 2010, at 1:25 PM, Sebastian Rose wrote: Hi everyone, here's a patch for org-html.el to fix those IDs. sec-1.2=> sec-

Re: [Orgmode] org-mode CSS property export bug

2010-04-24 Thread Sebastian Rose
Hi everyone, here's a patch for org-html.el to fix those IDs. sec-1.2=> sec-1_2 sec-1.2.3 => sec-1_2_3 diff --git a/lisp/org-html.el b/lisp/org-html.el index 71f62eb..133bffa 100644 --- a/lisp/org-html.el +++ b/lisp/org-html.el @@ -871,7 +871,9 @@ lang=\"%s\" xml:lang=\"%s\">

Re: [Orgmode] org-mode CSS property export bug

2010-04-24 Thread Sebastian Rose
Carsten Dominik writes: > On Apr 23, 2010, at 1:00 PM, Rick Moynihan wrote: > >> On 23 April 2010 11:46, Sebastian Rose wrote: >>> Very old browsers. Do we have to support them? >> >> I personally don't care for older browsers, though others may differ here. >> >>> The appended testfile works in

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Carsten Dominik
On Apr 23, 2010, at 1:00 PM, Rick Moynihan wrote: On 23 April 2010 11:46, Sebastian Rose wrote: Very old browsers. Do we have to support them? I personally don't care for older browsers, though others may differ here. The appended testfile works in Opera10 an FF 3.6. Is there something

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Carsten Dominik
On Apr 23, 2010, at 12:46 PM, Sebastian Rose wrote: Rick Moynihan writes: As far as I can see there are three options. 1) Use underscores (against the above advice) (practically probably not a huge issue) e.g. outline-container-1_1 2) Overload the use of hyphens to be for both spaces and .'s

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Carsten Dominik
On Apr 23, 2010, at 2:22 PM, Rick Moynihan wrote: On 23 April 2010 12:00, Rick Moynihan wrote: On 23 April 2010 11:46, Sebastian Rose wrote: Very old browsers. Do we have to support them? I personally don't care for older browsers, though others may differ here. The appended testfile

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Rick Moynihan
On 23 April 2010 12:00, Rick Moynihan wrote: > On 23 April 2010 11:46, Sebastian Rose wrote: >> Very old browsers. Do we have to support them? > > I personally don't care for older browsers, though others may differ here. > >> The appended testfile works in Opera10 an FF 3.6. Is there something >

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Rick Moynihan
On 23 April 2010 11:46, Sebastian Rose wrote: > Very old browsers. Do we have to support them? I personally don't care for older browsers, though others may differ here. > The appended testfile works in Opera10 an FF 3.6. Is there something > missing? It works also in Safari 4, and Chrome (both

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Sebastian Rose
Rick Moynihan writes: > As far as I can see there are three options. > > 1) Use underscores (against the above advice) (practically probably > not a huge issue) e.g. outline-container-1_1 > 2) Overload the use of hyphens to be for both spaces and .'s... e.g > outline-container-1-1 > 3) Stop using

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Rick Moynihan
On 23 April 2010 07:30, Carsten Dominik wrote: > > We could change . to _ , but that would break old links, so I am hesitating. > But of course if this really violates standards, we can change it. > > Sebastian has the last word on these issues. Unfortunately it seems that underscores, though no-

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Sebastian Rose
Carsten Dominik writes: > On Apr 23, 2010, at 3:51 AM, Rick Moynihan wrote: > >> On 22 April 2010 22:29, Sebastian Rose wrote: >>> Rick Moynihan writes: >>> >>> Hey Rick, >>> >>> interesting observation! I found, the pages validate everywhere, and so >>> I started to search. It seems to be valid

Re: [Orgmode] org-mode CSS property export bug

2010-04-23 Thread Carsten Dominik
On Apr 23, 2010, at 3:51 AM, Rick Moynihan wrote: On 22 April 2010 22:29, Sebastian Rose wrote: Rick Moynihan writes: Hey Rick, interesting observation! I found, the pages validate everywhere, and so I started to search. It seems to be valid CSS 2 (I couldn't find a evidence though).

Re: [Orgmode] org-mode CSS property export bug

2010-04-22 Thread Sebastian Rose
Rick Moynihan writes: > On 22 April 2010 22:29, Sebastian Rose wrote: >> Rick Moynihan writes: >> >> Hey Rick, >> >> interesting observation! I found, the pages validate everywhere, and so >> I started to search. It seems to be valid CSS 2 (I couldn't find a >> evidence though). > > Looks like

Re: [Orgmode] org-mode CSS property export bug

2010-04-22 Thread Rick Moynihan
On 22 April 2010 22:29, Sebastian Rose wrote: > Rick Moynihan writes: > > Hey Rick, > > interesting observation! I found, the pages validate everywhere, and so > I started to search. It seems to be valid CSS 2 (I couldn't find a > evidence though). Looks like an inconsistency in the W3C specs, a

Re: [Orgmode] org-mode CSS property export bug

2010-04-22 Thread Sebastian Rose
Rick Moynihan writes: > Hi all, > > It seems that org-mode exports invalid CSS properties for id's. > > e.g. "sec-1.1" is an invalid CSS ID because it collides with the > syntax for CSS classes, meaning that you can't style it. I'd suggest > replacing the dots with another char. Hey Rick, int

[Orgmode] org-mode CSS property export bug

2010-04-22 Thread Rick Moynihan
Hi all, It seems that org-mode exports invalid CSS properties for id's. e.g. "sec-1.1" is an invalid CSS ID because it collides with the syntax for CSS classes, meaning that you can't style it. I'd suggest replacing the dots with another char. R. __