[PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]

2024-02-09 Thread Martin Marshall
Hi, the docstring of `org-ctags-create-tags` says it should "(Re)create tags file in the directory of the active buffer," creating tags from the internal links found in the org files. However, it always creates an empty TAGS file. The cause appears to be a pair of escaped quotes used with `shell-

Re: [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]

2024-02-10 Thread Ihor Radchenko
Martin Marshall writes: > Hi, the docstring of `org-ctags-create-tags` says it should "(Re)create > tags file in the directory of the active buffer," creating tags from the > internal links found in the org files. However, it always creates an > empty TAGS file. > > The cause appears to be a pai

Re: [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]

2024-02-10 Thread Morgan Willcock
Ihor Radchenko writes: > Martin Marshall writes: > >> Hi, the docstring of `org-ctags-create-tags` says it should "(Re)create >> tags file in the directory of the active buffer," creating tags from the >> internal links found in the org files. However, it always creates an >> empty TAGS file. >

Re: [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]

2024-02-10 Thread Ihor Radchenko
Morgan Willcock writes: >>> I've attached a patch against the current Emacs master branch. I hope >>> that's sufficient, given the minimal nature of the change. >> >> Thanks! >> Applied, onto main. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=981402a93 > > Doesn't this chan

Re: [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]

2024-03-19 Thread Max Nikulin
On 11/02/2024 04:10, Morgan Willcock wrote: The shell expansion should work if the asterisk is outside of the quotes. I've attached an (untested) patch to explain what I mean. Never try to quote arbitrary strings by double or single quotes in shell. There are enough fancy characters that may

Re: [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]

2024-03-20 Thread Ihor Radchenko
Max Nikulin writes: > The committed change is anyway incomplete. > ... May you submit a patch? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at