Re: [PATCH] Async session eval (2nd attempt)

2021-05-19 Thread Bastien
Hi Jack, Jack Kamm writes: >> Please feel free to commit this patch in master so that more people >> can test it, we can test and fix oddities while preparing for 9.5. > > OK, I have incorporated the minor fixes from Kyle's review and pushed to > master. Thanks a lot! -- Bastien

Re: [PATCH] Async session eval (2nd attempt)

2021-05-18 Thread Jack Kamm
Sorry for the noise, replying to add the X-Woof-Patch:applied header.

Re: [PATCH] Async session eval (2nd attempt)

2021-05-18 Thread Jack Kamm
Hi ian, ian martins writes: > I gave this a try and it works for me. One thing I noticed is that if you > run a call asynchronously, the final result ends up under the source block > instead of the call. In the example below both RESULTS were written after > I ran the call. > > #+name:

Re: [PATCH] Async session eval (2nd attempt)

2021-05-18 Thread Jack Kamm
Hi Bastien, Bastien writes: > Please feel free to commit this patch in master so that more people > can test it, we can test and fix oddities while preparing for 9.5. OK, I have incorporated the minor fixes from Kyle's review and pushed to master. Cheers, Jack

Re: [PATCH] Async session eval (2nd attempt)

2021-05-15 Thread Bastien
Hi Jack, Jack Kamm writes: > This patch adds asynchronous evaluation for session blocks in > Python. It also adds functionality to implement async session eval for > other languages using ob-comint.el. Please feel free to commit this patch in master so that more people can test it, we can test

Re: [PATCH] Async session eval (2nd attempt)

2021-04-25 Thread Bastien
Kyle Meyer writes: >> I also have an async implementation for ob-R that's ready after this is >> merged :) > > It's a bit disappointing that only one babel user has tested this out > and provided feedback, but please feel free to merge this whenever you > think it's ready. Strong +1 -- and

Re: [PATCH] Async session eval (2nd attempt)

2021-04-25 Thread ian martins
I gave this a try and it works for me. One thing I noticed is that if you run a call asynchronously, the final result ends up under the source block instead of the call. In the example below both RESULTS were written after I ran the call. #+name: test-call #+begin_src python :results

Re: [PATCH] Async session eval (2nd attempt)

2021-04-25 Thread Jack Kamm
Hi Timothy, > This is moving at a glacial pace, but I'd love to see this merged --- > there's clearly a lot of interest in this from the community if not > within this mailing list (ob-async which is more limited has 250 stars > on GitHub). Yes, this has taken far too long -- sorry about that.

Re: [PATCH] Async session eval (2nd attempt)

2021-04-25 Thread Timothy
Hi Jack, Kyle, This is moving at a glacial pace, but I'd love to see this merged --- there's clearly a lot of interest in this from the community if not within this mailing list (ob-async which is more limited has 250 stars on GitHub). Jack, do you think you might be able to make these tweaks

Re: [PATCH] Async session eval (2nd attempt)

2021-03-03 Thread Kyle Meyer
Jack Kamm writes: > I also have an async implementation for ob-R that's ready after this is > merged :) It's a bit disappointing that only one babel user has tested this out and provided feedback, but please feel free to merge this whenever you think it's ready. I'm very happy to leave the

Re: [PATCH] Async session eval (2nd attempt)

2021-02-28 Thread Timothy
Jack Kamm writes: > I'm attaching an updated patch rebased on master. Fantastic. Thanks for doing this. > ob-python session blocks don't use "return", so this should just be: Ah, oops  > The non-session case is substantially different, and I think it would > probably require a separate

Re: [PATCH] Async session eval (2nd attempt)

2021-02-28 Thread Jack Kamm
Hi Timothy, Many thanks for testing this out. > I just tried to give this a shot. > First up, I had to remove the ORG-NEWS part of the patch to be able to > provide it. It would be nice if you could update the patch so this > applies cleanly. I'm attaching an updated patch rebased on master. >

Re: [PATCH] Async session eval (2nd attempt)

2021-01-03 Thread TEC
Hi Jack, I love the look of this! Thanks for submitting a patch. Sorry it's taken so long for someone to take a look at it, I think a lot of the 'main' Org people have been pretty busy over the last few months. I just tried to give this a shot. First up, I had to remove the ORG-NEWS part of

Re: [PATCH] Async session eval (2nd attempt)

2020-11-08 Thread Kyle Meyer
Jack Kamm writes: > This patch adds asynchronous evaluation for session blocks in > Python. It also adds functionality to implement async session eval for > other languages using ob-comint.el. > > To test the attached patch, add ":async" to a Python session block > with a long computation (or

Re: [PATCH] Async session eval (2nd attempt)

2020-10-26 Thread Eric S Fraga
On Monday, 26 Oct 2020 at 10:23, stardiviner wrote: > This really is an good idea. Some other Babel languages like Ruby, JavaScript > might benefit from this ob-comint async evaluation. Awesome! Julia would benefit from this as well! My Julia jobs usually take minutes if not hours. I usually

Re: [PATCH] Async session eval (2nd attempt)

2020-10-26 Thread stardiviner
This really is an good idea. Some other Babel languages like Ruby, JavaScript might benefit from this ob-comint async evaluation. Awesome! Jack Kamm writes: > This patch adds asynchronous evaluation for session blocks in > Python. It also adds functionality to implement async session eval for

[PATCH] Async session eval (2nd attempt)

2020-10-25 Thread Jack Kamm
This patch adds asynchronous evaluation for session blocks in Python. It also adds functionality to implement async session eval for other languages using ob-comint.el. To test the attached patch, add ":async" to a Python session block with a long computation (or "time.sleep") in it. Upon