Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-03-01 Thread Ihor Radchenko
Bastien Guerry writes: >> Bastien, could you please check FSF records? > > I confirm Damien's FSF record is in order. Thanks! Added to contributor list: https://git.sr.ht/~bzg/worg/commit/ada245e4 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-28 Thread Bastien Guerry
Ihor Radchenko writes: > Damien Cassou writes: > >> I've signed the FSF copyright agreement in the context of my >> contributions to Emacs. Do I need to do any more paperwork? > > No, you don't. > Bastien, could you please check FSF records? I confirm Damien's FSF record is in order. --

Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-26 Thread Ihor Radchenko
Damien Cassou writes: > Subject: [PATCH] org.el: Avoid crash in `org-file-contents' in case of network > failure Applied, onto bugfix. Thanks for your contribution! https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f9aeba5dd -- Ihor Radchenko // yantar92, Org mode contributor,

Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-24 Thread Damien Cassou
Ihor Radchenko writes: > I think you forgot to attach the updated patch :) typical. I'm so sorry. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill >From c116e27a84972f9e12a869f2b4983bb84ee50b15 Mon Sep 17 00:00:00 2001

Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-24 Thread Ihor Radchenko
Damien Cassou writes: > I've signed the FSF copyright agreement in the context of my > contributions to Emacs. Do I need to do any more paperwork? No, you don't. Bastien, could you please check FSF records? >> I think that it will be a good idea to indicate in the `message' where >> the error

Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-23 Thread Damien Cassou
Hi Ihor, thank you for your review. Ihor Radchenko writes: > According to our records in https://orgmode.org/worg/contributors.html, > you haven't signed FSF copyright agreement. May you add a TINYCHANGE > cookie to the commit message as required by >

Re: [PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-22 Thread Ihor Radchenko
Damien Cassou writes: > * lisp/org.el (org-file-contents): Wrap the > `url-retrieve-synchronously' call into a `condition-case' block to > avoid throwing an error when NOERROR is non-nil. Thanks for the patch! Few comments. > Subject: [PATCH] Avoid crash in `org-file-contents' in case of

[PATCH] Avoid crash in `org-file-contents' in case of network failure

2023-02-18 Thread Damien Cassou
* lisp/org.el (org-file-contents): Wrap the `url-retrieve-synchronously' call into a `condition-case' block to avoid throwing an error when NOERROR is non-nil. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill >From