Re: [PATCH] Babel evaluation: location and timing information (v2)

2022-09-24 Thread Timothy
Hi All, I’ve now resolved all the documentation issues Ihor raised, and since there were no other concerns raised, I’ve just pushed this as e8a797e1437d7aef2ce414694d2b642683f79976. All the best, Timothy

Re: [PATCH] Babel evaluation: location and timing information (v2)

2022-09-23 Thread Ihor Radchenko
Timothy writes: > * lisp/ob-core.el (org-babel-execute-src-block, > org-babel-format-result): Record the babel execution time, and then > supplement the "Code block evaluation complete." (etc.) messages with > the execution time when >0.05s. I'd also mention the new optional arguments. > -(defu

Re: [PATCH] Babel evaluation: location and timing information (v2)

2022-09-23 Thread Timothy
Hi All, Ihor raised a concern about the time needed to determine element type. This information is now passed on from other parts of Org, so there’s no overhead from this any more. Since this also applies to inline types, I’ve switched to showing the point position instead of the line number. As

Re: [PATCH] Babel evaluation: location and timing information

2022-09-22 Thread Ihor Radchenko
Timothy writes: > Hi Ihor, > >>> - (message “executing %s code block%s…” >>> + (message “executing %s %s %s…” >>> (capitalize lang) >>> + (pcase (org-element-type (org-element-at-point)) >>> + (’src-block “code block”) >>> +

Re: [PATCH] Babel evaluation: location and timing information

2022-09-22 Thread Ihor Radchenko
Max Nikulin writes: > While I work with my notes file, performance degrades after some > operations. E.g. searches become significantly slower after caching > refile targets. Previous discussion of the issue: > Ihor Radchenko. Re: profiling latency in large org-mode buffers (under > both main

Re: [PATCH] Babel evaluation: location and timing information

2022-09-22 Thread Max Nikulin
On 22/09/2022 14:03, Timothy wrote: On 18/09/2022 10:09, Timothy wrote: and now this might look like so: ┌ │ executing Emacs-Lisp call on line 143… │ Code block evaluation complete (took 0.2s). └ I do not mind to have such feature, but I am unsure concerning its price. I just have trie

Re: [PATCH] Babel evaluation: location and timing information

2022-09-22 Thread Timothy
Hi Ihor, >> -(message “executing %s code block%s…” >> +(message “executing %s %s %s…” >> (capitalize lang) >> + (pcase (org-element-type (org-element-at-point)) >> + (’src-block “code block”) >> + (’b

Re: [PATCH] Babel evaluation: location and timing information

2022-09-22 Thread Timothy
Hi Max, > On 18/09/2022 10:09, Timothy wrote: >> and now this might look like so: >> ┌ >> │ executing Emacs-Lisp call on line 143… >> │ Code block evaluation complete (took 0.2s). >> └ > > I do not mind to have such feature, but I am unsure concerning its price. I > just > have tried > >

Re: [PATCH] Babel evaluation: location and timing information

2022-09-20 Thread Ihor Radchenko
Timothy writes: > - (message "executing %s code block%s..." > + (message "executing %s %s %s..." >(capitalize lang) > + (pcase (org-element-type (org-element-at-point)) > + ('src-block "code block") > +

Re: [PATCH] Babel evaluation: location and timing information

2022-09-19 Thread Max Nikulin
On 18/09/2022 10:09, Timothy wrote: and now this might look like so: ┌ │ executing Emacs-Lisp call on line 143... │ Code block evaluation complete (took 0.2s). └ I do not mind to have such feature, but I am unsure concerning its price. I just have tried (benchmark-run 1 (line-number

Re: [PATCH] Babel evaluation: location and timing information

2022-09-19 Thread Fraga, Eric
Dear Timothy, this looks very useful. I've not tested it but would ask for one (hopefully minor) addition: could the position information provided include point as well as line number? I tend to use 1 line per paragraph (with visual line mode and org indent mode) and some of my paragraphs might

[PATCH] Babel evaluation: location and timing information

2022-09-17 Thread Timothy
Hi All, This is a small set of patches to add a bit more information to the messages emitted in the course of babel evaluation. Specifically about ⁃ What type of element is responsible for the evaluation (source block, babel call, inline source) ⁃ Where the element is (if no name is set) ⁃ How