Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Ihor Radchenko
Robert Pluim writes: > >> What's a TINYCHANGE? > > Ihor> See https://orgmode.org/worg/org-contribute.html#first-patch > Ihor> We need to put this word at the end of commit messages for > contributors > Ihor> without FSF copyright assignment. > > The first patch I sent last week i

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Robert Pluim
> On Tue, 14 Jun 2022 22:19:23 +0800, Ihor Radchenko > said: Ihor> Robert Pluim writes: >>> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko said: >> Ihor> Daniel Fleischer writes: >> >> Thanks for the patch, merged. >> Ihor> BTW, should it be a T

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Ihor Radchenko
Robert Pluim writes: >> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko >> said: > > Ihor> Daniel Fleischer writes: > >> Thanks for the patch, merged. > > Ihor> BTW, should it be a TINYCHANGE? > > What's a TINYCHANGE? See https://orgmode.org/worg/org-contribute.html#fi

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Robert Pluim
> On Tue, 14 Jun 2022 22:04:10 +0800, Ihor Radchenko > said: Ihor> Daniel Fleischer writes: >> Thanks for the patch, merged. Ihor> BTW, should it be a TINYCHANGE? What's a TINYCHANGE? Robert --

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Ihor Radchenko
Daniel Fleischer writes: > Thanks for the patch, merged. BTW, should it be a TINYCHANGE? Best, Ihor

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Daniel Fleischer
Thanks for the patch, merged. Daniel Fleischer

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Robert Pluim
that. Updated patch attached Robert -- >From 2c75a28bff8842f731611ebd7838c5f13122ac4d Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Mon, 13 Jun 2022 16:15:10 +0200 Subject: [PATCH] Don't quote symbols in defcustom types * lisp/org-fold-core.el (org-fold-core-style): * lisp/o

Re: [PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Daniel Fleischer
Robert Pluim [2022-06-14 Tue 11:28] wrote: > A couple of places in org main quoted symbols in defcustom types, but > the type itself is already quoted, so thatʼs not necessary. Is it harmful though? > - (const :tag "Overlays" 'overlays) > - (const :tag "Text properties" 'text-p

[PATCH] Don't quote symbols in defcustom types

2022-06-14 Thread Robert Pluim
TCH] Don't quote symbols in defcustom types * lisp/org-fold-core.el (org-fold-core-style): * lisp/org-persist.el (org-persist-remote-files): (org-persist-default-expiry): Don't quote the symbol given as value for a const. --- lisp/org-fold-core.el | 4 ++-- lisp/org-persist.el | 4