Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-02 Thread Ihor Radchenko
Karl Fogel writes: > This is now beyond the "trivial fix" level of effort that I was > prepared to invest to make this warning go away. Like Rudolf > Adamkovič and others before him, I now retire to my country > estate, to simultaneously lick my wounds and rest on my laurels > (which I

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread tomas
On Wed, Nov 01, 2023 at 11:29:23AM -0500, Karl Fogel wrote: > [...] (which I guess is better than licking my > laurels and resting on my wounds). Don't underestimate Medirerranean cooking. Laurels can be... yummy :) Cheers -- t signature.asc Description: PGP signature

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread Karl Fogel
On 01 Nov 2023, Ihor Radchenko wrote: Bastien writes: Karl Fogel writes: Hi, everyone. Small fix attached -- it just makes a warning go away. Applied against the main branch, thanks! Unfortunately, fixing this warning breaks org-table logic and tests. See previous discussion in

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread Bastien Guerry
Ihor Radchenko writes: > I added a FIXME explaining the issue to make the problem more clear. Good idea, thanks! -- Bastien Guerry

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread Ihor Radchenko
Bastien writes: >> Unfortunately, fixing this warning breaks org-table logic and tests. >> See previous discussion in >> https://list.orgmode.org/orgmode/20230827214320.46754-1-salu...@me.com/ > > Ouch. Reverted. I added a FIXME explaining the issue to make the problem more clear. I think this

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread Bastien
Ihor Radchenko writes: > Bastien writes: > >> Karl Fogel writes: >> >>> Hi, everyone. Small fix attached -- it just makes a warning go >>> away. >> >> Applied against the main branch, thanks! > > Unfortunately, fixing this warning breaks org-table logic and tests. > See previous discussion in

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread Ihor Radchenko
Bastien writes: > Karl Fogel writes: > >> Hi, everyone. Small fix attached -- it just makes a warning go >> away. > > Applied against the main branch, thanks! Unfortunately, fixing this warning breaks org-table logic and tests. See previous discussion in

Re: [PATCH] Fix warning about using `eq' to compare strings.

2023-11-01 Thread Bastien
Hi Karl, Karl Fogel writes: > Hi, everyone. Small fix attached -- it just makes a warning go > away. Applied against the main branch, thanks! -- Bastien

[PATCH] Fix warning about using `eq' to compare strings.

2023-10-30 Thread Karl Fogel
Hi, everyone. Small fix attached -- it just makes a warning go away. Best regards, -Karl >From a1a939191af1a195f260037510d407e7483ba05f Mon Sep 17 00:00:00 2001 From: Karl Fogel Date: Mon, 30 Oct 2023 10:33:29 -0500 Subject: [PATCH] lisp/org-table.el: fix warning about `eq' usage *