[PATCH] Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)

2022-11-12 Thread Ihor Radchenko
Timothy writes: >>> Sure. Just trying to clarify my confusion. The inconsistency with some >>> defcustoms using :version and some not is bugging me. >> >> Agreed. It would be better to be consistent with this. > > Given that org-mode is distributed separately to Emacs, and I get the > impressio

Re: [PATCH] Improve look of agenda on graphical displays

2022-06-30 Thread Ihor Radchenko
Stefan Kangas writes: > The attached patch improves the look of the agenda time grid and > separator line on graphical displays. It was inspired by > org-modern.el by Daniel Mendler. Applied onto main via 998a0aacd. Best, Ihor

Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)

2022-06-29 Thread Bruce D'Arcus
On Wed, Jun 29, 2022 at 10:23 AM Timothy wrote: > > Hi Ihor and Stefan, > > >> Sure. Just trying to clarify my confusion. The inconsistency with some > >> defcustoms using :version and some not is bugging me. > > > > Agreed. It would be better to be consistent with this. > > Given that org-mode i

Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)

2022-06-29 Thread Timothy
Hi Ihor and Stefan, >> Sure. Just trying to clarify my confusion. The inconsistency with some >> defcustoms using :version and some not is bugging me. > > Agreed. It would be better to be consistent with this. Given that org-mode is distributed separately to Emacs, and I get the impression havin

[STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)

2022-06-29 Thread Ihor Radchenko
Stefan Kangas writes: >> I am wondering if this is meaningful considering that Org is not always >> distributed together with Emacs. Will this :version tag make any sense >> for people using the newest Org with older Emacs versions? > > I think it won't really, but that's okay. Also, this is how

Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays)

2022-06-29 Thread Stefan Kangas
Ihor Radchenko writes: > Sure. Just trying to clarify my confusion. The inconsistency with some > defcustoms using :version and some not is bugging me. Agreed. It would be better to be consistent with this.

Re: [PATCH] Improve look of agenda on graphical displays

2022-06-29 Thread Stefan Kangas
Ihor Radchenko writes: > >:group 'org-agenda > > + :version "29.1" > > ... > > - :version "24.1" > > + :version "29.1" > >:type 'string) > > I am wondering if this is meaningful considering that Org is not always > distributed together with Emacs. Will this :version tag make any sense

Re: [PATCH] Improve look of agenda on graphical displays

2022-06-29 Thread Ihor Radchenko
Stefan Kangas writes: > The attached patch improves the look of the agenda time grid and > separator line on graphical displays. It was inspired by > org-modern.el by Daniel Mendler. Thanks! Looks good. >:group 'org-agenda > + :version "29.1" > ... > - :version "24.1" > + :version "29.1

[PATCH] Improve look of agenda on graphical displays

2022-06-27 Thread Stefan Kangas
: [PATCH] Improve look of agenda on graphical displays * lisp/org-agenda.el (org-agenda-block-separator) (org-agenda-time-grid, org-agenda-current-time-string): Improve default visual elements on graphical displays. Inspired by org-modern.el by Daniel Mendler . --- lisp/org-agenda.el | 27