Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-26 Thread Bastien
Jim Porter writes: > On 9/25/2021 10:58 PM, Bastien wrote: >> I applied the patch adding the TINYCHANGE cookie, since the assignment >> process isn't done yet. Can you check with copyright-cl...@fsf.org if >> it will be done anytime soon? > > I think I might be in the database as "James" though;

Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-26 Thread Jim Porter
On 9/25/2021 10:58 PM, Bastien wrote: I applied the patch adding the TINYCHANGE cookie, since the assignment process isn't done yet. Can you check with copyright-cl...@fsf.org if it will be done anytime soon? Hm, it should be done, since I received confirmation from the copyright clerk on the

Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-25 Thread Bastien
Hi Jim, Jim Porter writes: > The attached patch fixes both of these issues. For the first problem, > maybe it would be useful to put the regexp for checkboxes in a variable > somewhere so it doesn't get out of sync. I wasn't sure though, so I went > with the simpler solution for now. Applied

Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-18 Thread Jim Porter
On 9/18/2021 1:54 PM, Samuel Wales wrote: thanks for this. if tests are written, might be useful to include the case where half-checked are parents. I tested manually, and this behaves how I'd expect; not surprising, since it just calls `org-toggle-checkbox'. Maybe there's an argument that p

Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-18 Thread Samuel Wales
thanks for this. if tests are written, might be useful to include the case where half-checked are parents. On 9/18/21, Jim Porter wrote: > While trying out `org-mouse', I noticed two semi-related issues with > checkboxes. First, intermediate-state checkboxes (like [-]) aren't > clickable. Second

[PATCH] Improve org-mouse support for checkboxes

2021-09-18 Thread Jim Porter
While trying out `org-mouse', I noticed two semi-related issues with checkboxes. First, intermediate-state checkboxes (like [-]) aren't clickable. Second, if the checkboxes are inside a block and the theme gives the block a background color, the block's background is removed behind the checkbox